RFR 8175383: JVM should throw NCDFE if ACC_MODULE and CONSTANT_Module/Package are set

[harold seigel]

Thanks John!

I'll add a field to the CFP object, hopefully without increasing its size.

Harold


On 3/2/2017 8:12 AM, John Rose wrote:
> On Mar 2, 2017, at 1:05 PM, John Rose <john.r.rose at oracle.com 
> <mailto:john.r.rose at oracle.com>> wrote:
>>
>> I think the bug JDK-8175383 should give the reasons (either JVMS 
>> language or use case) why the more convenient CFE would be a bad 
>> outcome.  In other words, why are we doing this?
>
> P.S.  I have a specific comment on the source code style:
>
> Please return the extra result not by replacing the "void" return 
> value, but by passing an out-parameter and/or a field in the CFP object.
>
> You can have a boolean "_bad_constant_seen".  This is much clearer and 
> less disruptive than taking over the return value.  Your patch size 
> will collapse.
>
> — John