RFR 8172514: Stop checking for duplicate packages in the JVM_DefineModule() package list

harold seigel harold.seigel at oracle.com
Thu Mar 9 16:21:38 UTC 2017


Thanks Claes!

Here's the correct open webrev URL: 
http://cr.openjdk.java.net/~hseigel/bug_8172514/webrev/index.html

Harold


On 3/9/2017 11:15 AM, Claes Redestad wrote:
> Looks good to me!
>
> (You might want to host the webrev on cr.openjdk.java.net, though..)
>
> /Claes
>
> On 03/09/2017 04:44 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 fix to removing checking for duplicate 
>> packages in the package list passed to JVM_DefineModule().  The 
>> checking is potentially expensive and also redundant because the JDK 
>> makes the same check.
>>
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8172514
>>
>> The fix was tested with the JCK lang and vm tests, the JTreg hotspot, 
>> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5 
>> tests, the co-located and non-colocated NSK tests, and with JPRT.
>>
>> Thanks, Harold
>>
>



More information about the hotspot-runtime-dev mailing list