RFR 8176471: [TESTBUG] runtime/modules/IgnoreModulePropertiesTest.java fails with OpenJDK: java.lang.RuntimeException: 'java version ' missing from stdout/stderr

David Holmes david.holmes at oracle.com
Tue Mar 14 00:37:31 UTC 2017


Hi Harold,

On 14/03/2017 5:18 AM, harold seigel wrote:
> Hi,
>
> Please review these fixes for two tests that incorrectly parse the
> output from 'java -version' commands for the open jdk build.

I agree these changes will "fix" the tests when run on OpenJDK build.

However I don't see how checking for these strings is actually testing 
anything relevant to the test being executed.

Thanks,
David

> Open Webrevs:
>
>    http://cr.openjdk.java.net/~hseigel/bug_8176471_jdk/webrev/
>
>    http://cr.openjdk.java.net/~hseigel/bug_8176471_hs/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8176471
>
> The fixed tests were tested on open fastdebug and product builds, and on
> a fastdebug closed build.
>
> Thanks, Harold
>
>


More information about the hotspot-runtime-dev mailing list