RFR: 8176593: Throwable::getStackTrace performance regression

Jiangli Zhou jiangli.zhou at oracle.com
Wed Mar 15 00:10:47 UTC 2017


+1

Thanks,
Jiangli

> On Mar 14, 2017, at 4:11 PM, coleen.phillimore at oracle.com wrote:
> 
> Looks good!
> Coleen
> 
> On 3/14/17 6:51 PM, serguei.spitsyn at oracle.com wrote:
>> Claes,
>> 
>> New webrev looks good.
>> Thank you for the update!
>> 
>> Thanks,
>> Serguei
>> 
>> 
>> On 3/14/17 15:28, Claes Redestad wrote:
>>> 
>>> 
>>> On 2017-03-14 21:39, coleen.phillimore at oracle.com wrote:
>>>> 
>>>> So I think the change is good as-is.
>>> 
>>> Thanks Coleen, Jiangli and Serguei!
>>> 
>>> As we discussed offline, however, the new and existing hash_string
>>> methods should be private:
>>> 
>>> http://cr.openjdk.java.net/~redestad/8176593/hotspot.03/
>>> 
>>> Also added the typo fix suggested by Serguei and updated copyrights.
>>> 
>>> Thanks!
>>> 
>>> /Claes
>>> 
>> 
> 



More information about the hotspot-runtime-dev mailing list