RFR 8176705: Remove static functions in InstanceKlass
Ioi Lam
ioi.lam at oracle.com
Mon Mar 20 00:36:49 UTC 2017
Hi Harold,
Looks good. Small nits:
(1) Maybe do_local_static_fields_impl should be folded into
do_local_static_fields(void f(fieldDescriptor*, Handle, TRAPS), Handle
mirror, TRAPS)?
(2) Same for set_initialization_state_and_notify vs
set_initialization_state_and_notify_impl; and call_class_initializer vs
call_class_initializer_impl.
Thanks
- Ioi
On 3/19/17 10:41 PM, harold seigel wrote:
> Hi,
>
> Please review this JDK-10 cleanup to convert certain static methods to
> instance methods in class InstanceKlass. These methods can now be
> instance methods as a result of the fix for JDK-8155672
> <https://bugs.openjdk.java.net/browse/JDK-8155672>.
>
> Open Webrev:
> http://cr.openjdk.java.net/~hseigel/bug_8176705/webrev/index.html
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8176705
>
> The change was tested with the JCK lang and vm tests, the JTreg
> hotspot, java/io, java/lang, java/util and other tests, the RBT tier2
> -tier5 tests, the colocated and non-colocated NSK tests, and with JPRT.
>
> Thanks, Harold
>
More information about the hotspot-runtime-dev
mailing list