RFR (XS): 8067728: Flag::unlock_diagnostic() should be called Flag::clear_diagnostic()

[Rachel Protacio]

Thanks for the reviews, Ioi, Harold, and David. Will check in.

And yes, there are a number of tests that use this code. But I'll leave 
the assert as well.

Rachel

On 5/3/2017 12:11 AM, David Holmes wrote:
> Hi Rachel,
>
> Looks good.
>
> Do we have any tests that clear the diagnostic bit? That would be 
> nicer for checking the logic instead of adding the assert Ioi suggested.
>
> Thanks,
> David
>
> On 3/05/2017 4:15 AM, Rachel Protacio wrote:
>> Hi,
>>
>> Please review this tiny change, renaming Flag::unlock_diagnostic() as
>> Flag::clear_diagnostic.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8067728
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8067728.00/
>>
>> Thanks!
>> Rachel