RFR(S): 8179953: [ppc] TLABWasteIncrement not loaded correctly

David Holmes david.holmes at oracle.com
Wed May 10 03:19:10 UTC 2017


Hi Goetz,

On 10/05/2017 12:56 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> Please review this change.  As I fix the test, I please need a sponsor.
> http://cr.openjdk.java.net/~goetz/wr17/8179953-ppc_flag/webrev.01/

I'm unclear on the test changes. It isn't obvious to me that 
TLABWasteIncrement is a ParallelGC only flag. By adding that as an 
additional flag you then had to exclude adding the GCType (if any GC 
selector is given) to avoid conflicting options - is that right?

Thanks,
David

> On ppc, the mentioned flag is loaded as a 16 bit immediate, while it can have
> bigger values.
> I also adapt TestOptionWithRanges, which did not show the bug because
> the flag has no effect with G1.
>
> Best regards,
>   Goetz.
>
>


More information about the hotspot-runtime-dev mailing list