RFR 8166848: Performance bug: SystemDictionary - optimization

[coleen.phillimore at oracle.com]

Gerard,

Thank you for the code review and help with this change.

Coleen

On 5/17/17 11:40 AM, Gerard Ziemski wrote:
> hi Coleen,
>
> Thank you for tackling this issue.
>
> Looks good to me and I like Serguei suggestion.
>
>
> cheers
>
>> On May 16, 2017, at 11:21 PM, serguei.spitsyn at oracle.com wrote:
>>
>> Hi Coleen,
>>
>> It looks good to me.
>> Nice simplification!
>>
>> One tip is to use the bucket_count for incrementing the element_count:
>>    element_count += bucket_count;
>>
>> out of the internal for-loop.
>> It is to underline the relationship between the two counters.
>>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 5/15/17 05:30, coleen.phillimore at oracle.com wrote:
>>>> Summary: Check instead that a bucket isn't 10x the average
>>>>
>>>> See bug and linked bugs for more details.
>>>>
>>>> Tested with RBT nightly tests (tier2-5).
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8166848.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8166848
>>>>
>>>> Thanks,
>>>> Coleen