RFR 8166848: Performance bug: SystemDictionary - optimization

[serguei.spitsyn at oracle.com]

Hi Coleen,

Looks good.
Thank you for the update!

Thanks,
Serguei


On 5/17/17 08:45, coleen.phillimore at oracle.com wrote:
>
> Hi Serguei, thank you for reviewing.
>
> On 5/17/17 12:21 AM, serguei.spitsyn at oracle.com wrote:
>> Hi Coleen,
>>
>> It looks good to me.
>> Nice simplification!
>>
>> One tip is to use the bucket_count for incrementing the element_count:
>>    element_count += bucket_count;
>>
>> out of the internal for-loop.
>> It is to underline the relationship between the two counters.
>
> This is a good suggestion.  I made this change and retested:
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8166848.02/webrev
>
> Thanks!
> Coleen
>>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 5/15/17 05:30, coleen.phillimore at oracle.com wrote:
>>>
>>>> Summary: Check instead that a bucket isn't 10x the average
>>>>
>>>> See bug and linked bugs for more details.
>>>>
>>>> Tested with RBT nightly tests (tier2-5).
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8166848.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8166848
>>>>
>>>> Thanks,
>>>> Coleen
>>>
>>
>