RFR(S): 8139673: NMT stack traces in output should show mtcomponent

[Zhengyu Gu]

Hi David,

Thanks for the review. I updated webrev according to your comments.

Webrev: http://cr.openjdk.java.net/~zgu/8139673/webrev.01/index.html

-Zhengyu


On 05/22/2017 09:46 PM, David Holmes wrote:
> On 23/05/2017 12:34 AM, Zhengyu Gu wrote:
>> I re-open this bug, as I received a new request for this functionality.
>>
>> The most of work was done by Max Ockner
>> (http://cr.openjdk.java.net/~mockner/8139673/). I only made to a few
>> twists to his patch to create malloc callsite for each memory type, if
>> the callsite is shared by multiple memory types, as Coleen suggested.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139673
>> Webrev: http://cr.openjdk.java.net/~zgu/8139673/webrev.00/
>
>
> src/share/vm/services/memReporter.cpp
>
> Can print_malloc(size_t amount, size_t count) not delegate to
> print_malloc(size_t amount, size_t count, MEMFLAGS flag) - can we have a
> default value for "flag"?
>
> ---
>
> Otherwise seems okay. Copyright years need updating.
>
> Thanks,
> David
>
>>
>> Thanks,
>>
>> -Zhengyu
>>