RFR(S): 8139673: NMT stack traces in output should show mtcomponent
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Tue May 23 16:56:58 UTC 2017
Zhengyu, Thank you for completing this change! I'll sponsor it and make
both you and Max authors, and add myself as reviewer.
Thanks,
Coleen
On 5/23/17 12:05 PM, Zhengyu Gu wrote:
> Hi Aleksey,
>
> Thanks for the review. I fixed double spaces in new webrev:
>
> http://cr.openjdk.java.net/~zgu/8139673/webrev.02/
>
> I do need sponsor the this, and please also add Max Ockner (mockner)
> as an author.
>
> Thanks,
>
> -Zhengyu
>
>
> On 05/23/2017 11:05 AM, Aleksey Shipilev wrote:
>> On 05/23/2017 03:33 PM, Zhengyu Gu wrote:
>>> Webrev: http://cr.openjdk.java.net/~zgu/8139673/webrev.01/index.html
>>
>> Looks good.
>>
>> Minor nit: there are some double spaces, fix them before pushing?
>>
>> 71 _malloc_site(stack, flags), _next(NULL) {
>>
>> ...
>>
>> 81 bool ret = MallocSiteTable::allocation_at(stack, size,
>> bucket_idx,
>> pos_idx, flags);
>>
>> Thanks,
>> -Aleksey
>>
>>
>>
More information about the hotspot-runtime-dev
mailing list