RFR(S): 8180631: [TESTBUG] CDS tests should use CDSTestUtils.executeAndLog whenever spawning sub processes

[Calvin Cheung]

Looks good.

thanks,
Calvin

On 5/23/17, 12:30 PM, Mikhailo Seledtsov wrote:
> Hi Calvin,
>
> Thank you for review. Good catch.
>
> I have updated this code block to properly use the utility method to 
> determine whether the mapping failed:
>
>                       output = CDSTestUtils.executeAndLog(pb, "use" + 
> counter);
>                       if(CDSTestUtils.isUnableToMap(output)) {
>                           System.out.println("Unable to use shared 
> archive: " +
>                                              "test not executed; 
> assumed passed");
>                           continue;
>                       } else {
>                           output.shouldHaveExitValue(0);
>                       }
>
> Here is the updated webrev: 
> http://cr.openjdk.java.net/~mseledtsov/8180631.05/
>
> Misha
>
> On 5/23/17, 11:43 AM, Calvin Cheung wrote:
>> Hi Misha,
>>
>> Just one comment on LimitedSharedSizes.java:
>>
>>   171                       try {
>>   172                           CDSTestUtils.executeAndLog(pb, "use" + counter)
>>   173                               .shouldContain("archive is valid");
>>
>> Do you need to cache the output in line 172 since you're checking it 
>> in the catch block?
>>
>> thanks,
>> Calvin
>>
>> On 5/18/17, 5:30 PM, Mikhailo Seledtsov wrote:
>>> Please review this simple change that uses 
>>> CDSTestUtils.executeAndLog() for starting child
>>> processes in CDS tests, in places that did not use this method 
>>> before. In short, this change brings
>>> benefits of recording the output of child processes thus aiding in 
>>> troubleshooting of failures.
>>> For more details see bug description.
>>>
>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8180631/
>>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8180631.01/
>>>     Testing:
>>>         CDS tests on Linux-x64 (local) - PASS
>>>         CDS tests via automated multi-platform test system - in 
>>> Progress
>>>
>>> Thank you,
>>> Misha