RFR (S): 8180755: Remove use of bitMap.inline.hpp include from instanceKlass.hpp and c1_ValueSet.hpp

David Holmes david.holmes at oracle.com
Thu May 25 08:01:36 UTC 2017


On 24/05/2017 11:28 PM, coleen.phillimore at oracle.com wrote:
> 
> 
> On 5/24/17 2:34 AM, Thomas Schatzl wrote:
>> Hi,
>>
>> On Wed, 2017-05-24 at 11:27 +1000, David Holmes wrote:
>>> On 24/05/2017 1:31 AM, Thomas Schatzl wrote:
>>>> Hi Coleen,
>>>>
>>>> On Tue, 2017-05-23 at 10:15 -0400, coleen.phillimore at oracle.com
>>>> wrote:
>>>>> http://cr.openjdk.java.net/~tschatzl/8180755/webrev.1/src/share/v
>>>>> m/oops/generateOopMap.cpp.udiff.html
>>>>>
>>>>> I don't think this should include methodHandles.hpp (I see you've
>>>>> rearranged it, can you try to remove it?)
>>> Why should it be removed? The file uses things from methodHandles.
> 
> I'm looking for this, but I don't see it.   methodHandles.hpp is for 
> JSR292 MethodHandles not the handle type for Method*.

Sorry - what terrible naming!

David

> Coleen
> 
>>    I will revert this change. Thanks for pointing this out.
>>
>> Thanks,
>>    Thomas
>>
> 


More information about the hotspot-runtime-dev mailing list