RFR JDK-8179861: Missing copyrights in some hotspot files

[serguei.spitsyn at oracle.com]

Hi George,

I've compared the hg logs with the copyright dates.
It looks good in general.

A question is about two files in:
   src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities

They both have one changeset dated by 2015 but the copyright headers 
have also the 2012 year.
Should they have just 2015 or I'm miss something?

Thanks,
Serguei



On 5/25/17 14:07, George Triantafillou wrote:
> Hi David,
>
> Here's a new webrev addressing the issues you raised:
>
> http://cr.openjdk.java.net/~gtriantafill/8179861-webrev/webrev.01/index.html 
> <http://cr.openjdk.java.net/%7Egtriantafill/8179861-webrev/webrev.01/index.html> 
>
>
> Comments inline:
>
> On 5/25/2017 4:38 AM, David Holmes wrote:
>> Hi George,
>>
>> On 25/05/2017 1:17 AM, George Triantafillou wrote:
>>> Please review this small fix to include missing copyrights in some 
>>> hotspot files:
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179861
>>> webrev: 
>>> http://cr.openjdk.java.net/~gtriantafill/8179861-webrev/webrev/index.html 
>>> <http://cr.openjdk.java.net/%7Egtriantafill/8179861-webrev/webrev/index.html> 
>>
>>
>>
>> test/runtime/6626217/Test6626217.sh
>>
>> You can't put a Java comment block in a shell script.
> That change was inadvertent and has been removed.
>>
>> Also note that the last copyright year reflects the most recent 
>> substantive change to a file. Adding the copyright notice is not such 
>> a change, so these don't all automatically get 2017 as the second year.
> All copyrights have been updated with the dates from hg log.
>
> Thanks for the review.
>
> -George
>>
>> Cheers,
>> David
>>
>>>
>>> Built and tested on Linux x64.
>>>
>>> Thanks.
>>>
>>> -George
>>>
>