RFR JDK-8179861: Missing copyrights in some hotspot files

David Holmes david.holmes at oracle.com
Fri May 26 00:33:34 UTC 2017


Hi George,

On 26/05/2017 7:07 AM, George Triantafillou wrote:
> Hi David,
> 
> Here's a new webrev addressing the issues you raised:
> 
> http://cr.openjdk.java.net/~gtriantafill/8179861-webrev/webrev.01/index.html 
> <http://cr.openjdk.java.net/%7Egtriantafill/8179861-webrev/webrev.01/index.html> 

Looks fine.

Thanks,
David

> 
> Comments inline:
> 
> On 5/25/2017 4:38 AM, David Holmes wrote:
>> Hi George,
>>
>> On 25/05/2017 1:17 AM, George Triantafillou wrote:
>>> Please review this small fix to include missing copyrights in some 
>>> hotspot files:
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179861
>>> webrev: 
>>> http://cr.openjdk.java.net/~gtriantafill/8179861-webrev/webrev/index.html 
>>> <http://cr.openjdk.java.net/%7Egtriantafill/8179861-webrev/webrev/index.html> 
>>
>>
>>
>> test/runtime/6626217/Test6626217.sh
>>
>> You can't put a Java comment block in a shell script.
> That change was inadvertent and has been removed.
>>
>> Also note that the last copyright year reflects the most recent 
>> substantive change to a file. Adding the copyright notice is not such 
>> a change, so these don't all automatically get 2017 as the second year.
> All copyrights have been updated with the dates from hg log.
> 
> Thanks for the review.
> 
> -George
>>
>> Cheers,
>> David
>>
>>>
>>> Built and tested on Linux x64.
>>>
>>> Thanks.
>>>
>>> -George
>>>
> 


More information about the hotspot-runtime-dev mailing list