RFR JDK-8179861: Missing copyrights in some hotspot files

[serguei.spitsyn at oracle.com]

Hi David,

Ok, thanks!
Serguei


On 5/25/17 17:31, David Holmes wrote:
> Hi Serguei,
>
> On 26/05/2017 10:08 AM, serguei.spitsyn at oracle.com wrote:
>> Hi George,
>>
>> I've compared the hg logs with the copyright dates.
>> It looks good in general.
>>
>> A question is about two files in:
>>    src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities
>>
>> They both have one changeset dated by 2015 but the copyright headers 
>> have also the 2012 year.
>> Should they have just 2015 or I'm miss something?
>
> These files were added in 2012 by:
>
> 6964458: Reimplement class meta-data storage to use native memory …
>
> eg. for IntArray ...
>
> Changeset: 3602 (da91efe96a93) 6964458: Reimplement class meta-data 
> storage to use native memory …
> User: coleenp
> Date: 2012-09-01 13:25:18 -0400 (2012-09-01)
> Parent: 3601 (36d1d483d5d6) 7195615: new hotspot build - hs25-b01 …
> Child: 3603 (03049e0e8544) 7195823: NPG: CMS reserved() doesn't match 
> _rs.base(). …
>
> David
> -----
>
>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 5/25/17 14:07, George Triantafillou wrote:
>>> Hi David,
>>>
>>> Here's a new webrev addressing the issues you raised:
>>>
>>> http://cr.openjdk.java.net/~gtriantafill/8179861-webrev/webrev.01/index.html 
>>> <http://cr.openjdk.java.net/%7Egtriantafill/8179861-webrev/webrev.01/index.html> 
>>>
>>>
>>> Comments inline:
>>>
>>> On 5/25/2017 4:38 AM, David Holmes wrote:
>>>> Hi George,
>>>>
>>>> On 25/05/2017 1:17 AM, George Triantafillou wrote:
>>>>> Please review this small fix to include missing copyrights in some 
>>>>> hotspot files:
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179861
>>>>> webrev: 
>>>>> http://cr.openjdk.java.net/~gtriantafill/8179861-webrev/webrev/index.html 
>>>>> <http://cr.openjdk.java.net/%7Egtriantafill/8179861-webrev/webrev/index.html> 
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> test/runtime/6626217/Test6626217.sh
>>>>
>>>> You can't put a Java comment block in a shell script.
>>> That change was inadvertent and has been removed.
>>>>
>>>> Also note that the last copyright year reflects the most recent 
>>>> substantive change to a file. Adding the copyright notice is not 
>>>> such a change, so these don't all automatically get 2017 as the 
>>>> second year.
>>> All copyrights have been updated with the dates from hg log.
>>>
>>> Thanks for the review.
>>>
>>> -George
>>>>
>>>> Cheers,
>>>> David
>>>>
>>>>>
>>>>> Built and tested on Linux x64.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> -George
>>>>>
>>>
>>