RFR: 8184765: Dynamically resize SystemDictionary

Gerard Ziemski gerard.ziemski at oracle.com
Wed Nov 1 19:40:21 UTC 2017


hi Robin,

Thank you for the review.

Just for completeness, the final rev4, updated with your feedback is here: http://cr.openjdk.java.net/~gziemski/8184765_rev4


cheers

> On Nov 1, 2017, at 10:45 AM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
> 
> Hi Gerard,
> 
> I looked at your pending v4 version. As mentioned in other forums the jtreg test should preferably be named TestXXX while the helper not starting with Test.
> 
> I don't need to see another webrev.
> 
> Looks good, thanks for fixing!
> 
> /Robbin
> 
> On 10/10/2017 10:40 PM, Gerard Ziemski wrote:
>> hi all,
>> Please review this change that adds dynamic resizing of system dictionaries.
>> The biggest change is refactoring of the code that protects calculating of the table entry’s index using SystemDictionary_lock
>> A few notes:
>> - dynamic resizing is off when either dumping or using shared spaces
>> - we remove the experimental runtime option “PredictedLoadedClassCount” and add “DynamicallyResizeSystemDictionaries” to turn the resizing off (it’s on by default)
>> - the jtreg test uses stream of bytes to dynamically load numbered classes from memory instead of disk (thank you Ioi)
>> bug:    https://bugs.openjdk.java.net/browse/JDK-8184765
>> webrev: http://cr.openjdk.java.net/~gziemski/8184765_rev1
>> cheers



More information about the hotspot-runtime-dev mailing list