RFR(M): 8189762: [TESTBUG] Create tests for JDK-8146115 container awareness and resource configuration

Bob Vandette bob.vandette at oracle.com
Fri Nov 3 18:04:27 UTC 2017


http://cr.openjdk.java.net/~mseledtsov/8189762.00/test/hotspot/jtreg/runtime/containers/docker/CPUSetsReader.java.html

Not sure this is a problem but  If you specify --cpuset-cpus 2-3,1 in docker you end up with cpuset.cpus containing 1-3.

Your cpusets test cases are all increasing in order so you won’t hit this issue.

The read function in this file has a hard coded /sys/fs/cgroup/cpuset directory.  This may not be where this
ends up being mounted.  Is this read function even used?


http://cr.openjdk.java.net/~mseledtsov/8189762.00/test/hotspot/jtreg/runtime/containers/docker/TestCPUAwareness.java.html

Your test assumes that there are at least two physical processors on the host.  You might want to check first.

 55             testAPCCombo("0,1", 200*1000, 100*1000, 4*1024, 2);
 56             testAPCCombo("0,1", 200*1000, 100*1000, 1*1024, 2)

Everything else looks good,
bob.


> On Nov 1, 2017, at 11:11 PM, mikhailo <mikhailo.seledtsov at oracle.com> wrote:
> 
> Please review these tests that were developed to test JVM's container awareness in Docker environment.
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8189762
>     Webrev:
>       Tests: http://cr.openjdk.java.net/~mseledtsov/8189762.00/
>       WB API: http://cr.openjdk.java.net/~mseledtsov/8189762.00.whitebox/
>     Testing:
>         1. Locally: Linux-x64, docker engine version: 17.06.2-ce
>            Ran the developed tests via jtreg
>            Pass
> 
>         2. Automated testing system - run these tests
>            In progress
> 
> Thank you,
> Misha
> 



More information about the hotspot-runtime-dev mailing list