RFR: SA: JDK-8189798: SA cleanup - part 1
Jini George
jini.george at oracle.com
Tue Nov 7 09:24:54 UTC 2017
Thank you very much, Sharath, for the review. My response inline:
On 11/3/2017 3:44 PM, Sharath Ballal wrote:
> Hi Jini,
>
> You have appended 'Field' for most of the SA variables. Example:
>
> private static CIntegerField pcOffsetField;
> pcOffsetField = type.getCIntegerField("_pc_offset");
>
> However that is not the case in
> private static long MinChunkSizeInBytes;
> MinChunkSizeInBytes = (type.getCIntegerField("_min_chunk_size_in_bytes")).getValue();
>
> You may want to follow the same convention here.
[Jini]: Unlike in the other cases, for MinChunkSizeInBytes, we are
getting and storing the __value__ of the Field rather than the Field
itself. Hence, I feel it might make more sense to not have 'Field' in
this name.
Thanks,
Jini.
> Rest of the changes look ok.
>
> Thanks,
> Sharath (not a reviewer)
>
>
> -----Original Message-----
> From: Jini George
> Sent: Thursday, November 02, 2017 10:24 AM
> To: Serguei Spitsyn; serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net; hotspot-dev at openjdk.java.net
> Subject: Re: RFR: SA: JDK-8189798: SA cleanup - part 1
>
> Could I please get one more review done for this ?
>
> Thanks,
> Jini.
>
> On 10/27/2017 9:19 PM, Jini George wrote:
>> Thank you very much, Serguei.
>>
>> -Jini.
>>
>> On 10/27/2017 2:22 PM, serguei.spitsyn at oracle.com wrote:
>>> Hi Jini,
>>>
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 10/24/17 00:31, Jini George wrote:
>>>> Adding hotspot-dev too.
>>>>
>>>> Thanks,
>>>> Jini.
>>>>
>>>> On 10/24/2017 12:05 PM, Jini George wrote:
>>>>> Hello,
>>>>>
>>>>> As a part of SA next, I am working on writing a test case which
>>>>> compares the fields and the types of the fields of the SA java
>>>>> classes with the corresponding entries in the vmStructs tables.
>>>>> This, to some extent, would help in preventing errors in SA due to
>>>>> the changes in hotspot. As a precursor to this, I am in the process
>>>>> of making some cleanup related changes (mostly in SA). I plan to
>>>>> have the changes done in parts. For this webrev, most of the
>>>>> changes are for:
>>>>>
>>>>> 1. Avoiding having some values being redefined in SA. Instead have
>>>>> those exported through vmStructs, and read it in SA.
>>>>> (CompactibleFreeListSpace::_min_chunk_size_in_bytes,
>>>>> CompactibleFreeListSpace::IndexSetSize)
>>>>>
>>>>> Redefinition of hotspot values in SA makes SA error prone, when the
>>>>> value gets altered in hotspot and the corresponding modification
>>>>> gets missed out in SA.
>>>>>
>>>>> 2. To remove some unused code (JNIid.java).
>>>>> 3. Add the missing "CMSBitMap::_bmStartWord" in vmStructs.
>>>>> 4. Modify variable names in SA and hotspot to match the counterpart
>>>>> names, so that the comparison of the fields become easier. Most of
>>>>> the changes belong to this group.
>>>>>
>>>>> Could I please get reviews done for these precursor changes ?
>>>>>
>>>>> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8189798
>>>>> webrev: http://cr.openjdk.java.net/~jgeorge/8189798/webrev.00/
>>>>>
>>>>> Thank you,
>>>>> Jini.
>>>>>
>>>
> X-sender: <serviceability-dev-bounces at openjdk.java.net>
> X-Receiver: <axel.siebenborn at sap.com>
> X-CreatedBy: MSExchange15
> X-HeloDomain: mx.expurgate.net
> X-ExtendedProps: BQBjAAoAqbJ+Vtsd1QgFADcAAgAADwA8AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50Lk9yZ2FuaXphdGlvblNjb3BlEQAAAAAAAAAAAAAAAAAAAAAADwAJAAAAQ0lBdWRpdGVkAgABBQBJAAIAAQUAYgAKAGcrAAB2AAAABQBkAA8ABAAAAEVkZ2U=
> X-Source: SMTP:External Receive Connector
> X-SourceIPAddress: 195.190.135.10
> X-EndOfInjectedXHeaders: 7733
> Received: from mx.expurgate.net (195.190.135.10) by smtpgw03.sap-ag.de
> (155.56.66.98) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 2 Nov
> 2017 05:54:39 +0100
> Received: from mx.expurgate.net (helo=localhost)
> by mx.expurgate.net with esmtp
> id 1eA7WZ-000EZw-D4
> for axel.siebenborn at sap.com; Thu, 02 Nov 2017 05:54:39 +0100
> Received: from [156.151.31.69] (helo=ucsinet41.oracle.com)
> by mxtls.expurgate.net with ESMTPS (eXpurgate 4.2.1-3)
> (envelope-from <serviceability-dev-bounces at openjdk.java.net>)
> id 59faa50b-7c01-c0a8033409dd-9c971f454783-3
> for <multiple-recipients>; Thu, 02 Nov 2017 05:54:38 +0100
> Received: from aojmv0009 (unknown [137.254.59.6]) by ucsinet41.oracle.com with smtp
> id 4eb7_00c7_3ecf1c93_28fd_4a9f_97f0_f31de9ddb295;
> Thu, 02 Nov 2017 04:54:17 +0000
> Received: from aojmv0009.oracle.com (localhost [127.0.0.1])
> by aojmv0009 (Postfix) with ESMTP id 15A99229CEC;
> Thu, 2 Nov 2017 04:57:26 +0000 (UTC)
> X-Original-To: serviceability-dev at openjdk.java.net
> Delivered-To: serviceability-dev at openjdk.java.net
> Received: from ucsinet40.oracle.com (ucsinet40.oracle.com [156.151.31.68]) by aojmv0009 (Postfix) with ESMTP id 9CFF6229CC3; Thu, 2 Nov 2017 04:57:20 +0000 (UTC)
> Received: from userp1040.oracle.com (unknown [156.151.31.81]) by ucsinet40.oracle.com with smtp
> (TLS: TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-GCM-SHA384)
> id 37c3_8726_79982056_f63b_491d_a8be_57819e8c7dcc;
> Thu, 02 Nov 2017 04:54:08 +0000
> Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
> vA24s8KW028461
> (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Nov 2017 04:54:08 GMT
> Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s84O013997
> (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Nov 2017 04:54:08 GMT
> Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s7KK017107; Thu, 2 Nov 2017 04:54:08 GMT
> Received: from [10.177.158.142] (/10.177.158.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 01 Nov 2017 21:54:07 -0700
> Subject: Re: RFR: SA: JDK-8189798: SA cleanup - part 1
> From: Jini George <jini.george at oracle.com>
> To: "serguei.spitsyn at oracle.com" <serguei.spitsyn at oracle.com>,
> "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>,
> "hotspot-runtime-dev at openjdk.java.net"
> <hotspot-runtime-dev at openjdk.java.net>, <hotspot-dev at openjdk.java.net>
> References: <18501902-23db-de6c-b83d-640cd33df836 at oracle.com>
> <e7cf9e4a-7986-317d-56dc-7594e0b3c798 at oracle.com>
> <691d8166-5395-906a-4256-ef0ab2e2773a at oracle.com>
> <f5483c7b-68ea-723f-6bd6-e2fe5d3d4570 at oracle.com>
> Organization: Oracle Corporation
> Message-ID: <6b40cba4-fc4e-dc54-a506-62f64599331e at oracle.com>
> Date: Thu, 2 Nov 2017 10:24:03 +0530
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
> Thunderbird/52.4.0
> MIME-Version: 1.0
> In-Reply-To: <f5483c7b-68ea-723f-6bd6-e2fe5d3d4570 at oracle.com>
> Content-Type: text/plain; charset="utf-8"; format=flowed
> Content-Language: en-US
> Content-Transfer-Encoding: 7bit
> X-Source-IP: userv0022.oracle.com [156.151.31.74]
> X-BeenThere: serviceability-dev at openjdk.java.net
> X-Mailman-Version: 2.1.17
> Precedence: list
> List-Id: "Technical discussion about the development of serviceability technologies \(debugging, profiling, monitoring, and management\)" <serviceability-dev.openjdk.java.net>
> List-Unsubscribe: <http://mail.openjdk.java.net/mailman/options/serviceability-dev>,
> <mailto:serviceability-dev-request at openjdk.java.net?subject=unsubscribe>
> List-Archive: <http://mail.openjdk.java.net/pipermail/serviceability-dev/>
> List-Post: <mailto:serviceability-dev at openjdk.java.net>
> List-Help: <mailto:serviceability-dev-request at openjdk.java.net?subject=help>
> List-Subscribe: <http://mail.openjdk.java.net/mailman/listinfo/serviceability-dev>,
> <mailto:serviceability-dev-request at openjdk.java.net?subject=subscribe>
> Errors-To: serviceability-dev-bounces at openjdk.java.net
> Sender: serviceability-dev <serviceability-dev-bounces at openjdk.java.net>
> X-purgate-ID: tlsNG-9b91ac/1509598479-00007C01-219CB02A/0/0
> X-purgate-type: clean
> X-purgate-size: 2000
> X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de
> Comment: eleven transport token MTU2LjE1MS4zMS42OQBzZXJ2aWNlYWJpbGl0eS1kZXYtYm91bmNlc0BvcGVuamRrLmphdmEubmV0AGF4ZWwuc2llYmVuYm9ybkBzYXAuY29tADgwYzQ2ZTI0N2Q2MTBlYjNiNTQ5MmE5YWE2NzJjNzJjN2NiNjcwNDQ=
> X-purgate: This mail is considered clean (visit http://www.eleven.de for further information)
> X-purgate: clean
> X-SAP-SPAM-Status: clean
> Return-Path: serviceability-dev-bounces at openjdk.java.net
> X-MS-Exchange-Organization-OriginalArrivalTime: 02 Nov 2017 04:54:39.6785
> (UTC)
> X-MS-Exchange-Organization-OriginalClientIPAddress: 195.190.135.10
> X-MS-Exchange-Organization-OriginalServerIPAddress: 155.56.66.98
> X-MS-Exchange-Organization-AuthSource: DEWDFE13EDGE01.wdf.sap.corp
> X-MS-Exchange-Organization-AuthAs: Anonymous
> X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: DEWDFE13EDGE01.wdf.sap.corp
> X-MS-Exchange-Organization-Network-Message-Id: 8fba1fcd-01cd-4a67-1ee6-08d521add313
> X-MS-Exchange-Organization-OriginalSize: 7400
> X-MS-Exchange-Organization-HygienePolicy: Standard
> X-MS-Exchange-Organization-MessageHighPrecisionLatencyInProgress:
> LSRV=DEWDFE13EDGE01.wdf.sap.corp:TOTAL-EDGE=11997.291|UTH=0.001|RST=11997.244|QS=0.029|CATCM-McAfeeTxRoutingAgent=0.011|CATCM=0.011|CAT=0.012;2017-11-02T08:14:36.969Z
>
> Could I please get one more review done for this ?
>
> Thanks,
> Jini.
>
> On 10/27/2017 9:19 PM, Jini George wrote:
>> Thank you very much, Serguei.
>>
>> -Jini.
>>
>> On 10/27/2017 2:22 PM, serguei.spitsyn at oracle.com wrote:
>>> Hi Jini,
>>>
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 10/24/17 00:31, Jini George wrote:
>>>> Adding hotspot-dev too.
>>>>
>>>> Thanks,
>>>> Jini.
>>>>
>>>> On 10/24/2017 12:05 PM, Jini George wrote:
>>>>> Hello,
>>>>>
>>>>> As a part of SA next, I am working on writing a test case which
>>>>> compares the fields and the types of the fields of the SA java
>>>>> classes with the corresponding entries in the vmStructs tables.
>>>>> This, to some extent, would help in preventing errors in SA due to
>>>>> the changes in hotspot. As a precursor to this, I am in the process
>>>>> of making some cleanup related changes (mostly in SA). I plan to
>>>>> have the changes done in parts. For this webrev, most of the
>>>>> changes are for:
>>>>>
>>>>> 1. Avoiding having some values being redefined in SA. Instead have
>>>>> those exported through vmStructs, and read it in SA.
>>>>> (CompactibleFreeListSpace::_min_chunk_size_in_bytes,
>>>>> CompactibleFreeListSpace::IndexSetSize)
>>>>>
>>>>> Redefinition of hotspot values in SA makes SA error prone, when the
>>>>> value gets altered in hotspot and the corresponding modification
>>>>> gets missed out in SA.
>>>>>
>>>>> 2. To remove some unused code (JNIid.java).
>>>>> 3. Add the missing "CMSBitMap::_bmStartWord" in vmStructs.
>>>>> 4. Modify variable names in SA and hotspot to match the counterpart
>>>>> names, so that the comparison of the fields become easier. Most of
>>>>> the changes belong to this group.
>>>>>
>>>>> Could I please get reviews done for these precursor changes ?
>>>>>
>>>>> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8189798
>>>>> webrev: http://cr.openjdk.java.net/~jgeorge/8189798/webrev.00/
>>>>>
>>>>> Thank you,
>>>>> Jini.
>>>>>
>>>
> X-sender: <hotspot-runtime-dev-bounces at openjdk.java.net>
> X-Receiver: <axel.siebenborn at sap.com>
> X-CreatedBy: MSExchange15
> X-HeloDomain: mx.expurgate.net
> X-ExtendedProps: BQBjAAoAALN+Vtsd1QgFADcAAgAADwA8AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50Lk9yZ2FuaXphdGlvblNjb3BlEQAAAAAAAAAAAAAAAAAAAAAADwAJAAAAQ0lBdWRpdGVkAgABBQBJAAIAAQUAYgAKAIMrAAB2AAAABQBkAA8ABAAAAEVkZ2U=
> X-Source: SMTP:External Receive Connector
> X-SourceIPAddress: 194.145.224.110
> X-EndOfInjectedXHeaders: 7704
> Received: from mx.expurgate.net (194.145.224.110) by smtpgw03.sap-ag.de
> (155.56.66.98) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 2 Nov
> 2017 05:54:46 +0100
> Received: from mx.expurgate.net (helo=localhost)
> by mx.expurgate.net with esmtp
> id 1eA7Wg-0004R0-FP
> for axel.siebenborn at sap.com; Thu, 02 Nov 2017 05:54:46 +0100
> Received: from [141.146.126.229] (helo=acsinet41.oracle.com)
> by mxtls.expurgate.net with ESMTPS (eXpurgate 4.3.1)
> (envelope-from <hotspot-runtime-dev-bounces at openjdk.java.net>)
> id 59faa50f-65eb-c0a8029b09dd-8d927ee53db9-3
> for <multiple-recipients>; Thu, 02 Nov 2017 05:54:45 +0100
> Received: from aojmv0009 (aojmv0009.oracle.com [137.254.59.6]) by acsinet41.oracle.com with smtp
> id 6461_15f0_154b24ba_5aa0_408c_88bd_1cdb37c9c8f4;
> Thu, 02 Nov 2017 04:54:31 +0000
> Received: from aojmv0009.oracle.com (localhost [127.0.0.1])
> by aojmv0009 (Postfix) with ESMTP id 3B280229CF4;
> Thu, 2 Nov 2017 04:57:26 +0000 (UTC)
> X-Original-To: hotspot-runtime-dev at openjdk.java.net
> Delivered-To: hotspot-runtime-dev at openjdk.java.net
> Received: from ucsinet40.oracle.com (ucsinet40.oracle.com [156.151.31.68]) by aojmv0009 (Postfix) with ESMTP id 9CFF6229CC3; Thu, 2 Nov 2017 04:57:20 +0000 (UTC)
> Received: from userp1040.oracle.com (unknown [156.151.31.81]) by ucsinet40.oracle.com with smtp
> (TLS: TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-GCM-SHA384)
> id 37c3_8726_79982056_f63b_491d_a8be_57819e8c7dcc;
> Thu, 02 Nov 2017 04:54:08 +0000
> Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
> vA24s8KW028461
> (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Nov 2017 04:54:08 GMT
> Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s84O013997
> (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Nov 2017 04:54:08 GMT
> Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vA24s7KK017107; Thu, 2 Nov 2017 04:54:08 GMT
> Received: from [10.177.158.142] (/10.177.158.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 01 Nov 2017 21:54:07 -0700
> Subject: Re: RFR: SA: JDK-8189798: SA cleanup - part 1
> From: Jini George <jini.george at oracle.com>
> To: "serguei.spitsyn at oracle.com" <serguei.spitsyn at oracle.com>,
> "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>,
> "hotspot-runtime-dev at openjdk.java.net"
> <hotspot-runtime-dev at openjdk.java.net>, <hotspot-dev at openjdk.java.net>
> References: <18501902-23db-de6c-b83d-640cd33df836 at oracle.com>
> <e7cf9e4a-7986-317d-56dc-7594e0b3c798 at oracle.com>
> <691d8166-5395-906a-4256-ef0ab2e2773a at oracle.com>
> <f5483c7b-68ea-723f-6bd6-e2fe5d3d4570 at oracle.com>
> Organization: Oracle Corporation
> Message-ID: <6b40cba4-fc4e-dc54-a506-62f64599331e at oracle.com>
> Date: Thu, 2 Nov 2017 10:24:03 +0530
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
> Thunderbird/52.4.0
> MIME-Version: 1.0
> In-Reply-To: <f5483c7b-68ea-723f-6bd6-e2fe5d3d4570 at oracle.com>
> Content-Type: text/plain; charset="utf-8"; format=flowed
> Content-Language: en-US
> Content-Transfer-Encoding: 7bit
> X-Source-IP: userv0022.oracle.com [156.151.31.74]
> X-BeenThere: hotspot-runtime-dev at openjdk.java.net
> X-Mailman-Version: 2.1.17
> Precedence: list
> List-Id: Technical discussion about the development of the HotSpot runtime subsystem <hotspot-runtime-dev.openjdk.java.net>
> List-Unsubscribe: <http://mail.openjdk.java.net/mailman/options/hotspot-runtime-dev>,
> <mailto:hotspot-runtime-dev-request at openjdk.java.net?subject=unsubscribe>
> List-Archive: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/>
> List-Post: <mailto:hotspot-runtime-dev at openjdk.java.net>
> List-Help: <mailto:hotspot-runtime-dev-request at openjdk.java.net?subject=help>
> List-Subscribe: <http://mail.openjdk.java.net/mailman/listinfo/hotspot-runtime-dev>,
> <mailto:hotspot-runtime-dev-request at openjdk.java.net?subject=subscribe>
> Errors-To: hotspot-runtime-dev-bounces at openjdk.java.net
> Sender: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net>
> X-purgate-ID: tlsNG-81024b/1509598486-000065EB-186BA960/0/0
> X-purgate-type: clean
> X-purgate-size: 2000
> X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de
> Comment: eleven transport token MTQxLjE0Ni4xMjYuMjI5AGhvdHNwb3QtcnVudGltZS1kZXYtYm91bmNlc0BvcGVuamRrLmphdmEubmV0AGF4ZWwuc2llYmVuYm9ybkBzYXAuY29tADE0ZjI2NjVmYTY4ZGRiOWMwNGJiMGU0MmE2Njk2M2ZiNWQxNzAyOGI=
> X-purgate: This mail is considered clean (visit http://www.eleven.de for further information)
> X-purgate: clean
> X-SAP-SPAM-Status: clean
> Return-Path: hotspot-runtime-dev-bounces at openjdk.java.net
> X-MS-Exchange-Organization-OriginalArrivalTime: 02 Nov 2017 04:54:46.7566
> (UTC)
> X-MS-Exchange-Organization-OriginalClientIPAddress: 194.145.224.110
> X-MS-Exchange-Organization-OriginalServerIPAddress: 155.56.66.98
> X-MS-Exchange-Organization-AuthSource: DEWDFE13EDGE01.wdf.sap.corp
> X-MS-Exchange-Organization-AuthAs: Anonymous
> X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: DEWDFE13EDGE01.wdf.sap.corp
> X-MS-Exchange-Organization-Network-Message-Id: 9365fa06-08de-47df-2865-08d521add74b
> X-MS-Exchange-Organization-OriginalSize: 7380
> X-MS-Exchange-Organization-HygienePolicy: Standard
> X-MS-Exchange-Organization-MessageHighPrecisionLatencyInProgress:
> LSRV=DEWDFE13EDGE01.wdf.sap.corp:TOTAL-EDGE=11990.260|UTH=0.001|RST=11990.260|CATCM-McAfeeTxRoutingAgent=0.004|CATCM=0.005|CAT=0.006;2017-11-02T08:14:37.016Z
>
> Could I please get one more review done for this ?
>
> Thanks,
> Jini.
>
> On 10/27/2017 9:19 PM, Jini George wrote:
>> Thank you very much, Serguei.
>>
>> -Jini.
>>
>> On 10/27/2017 2:22 PM, serguei.spitsyn at oracle.com wrote:
>>> Hi Jini,
>>>
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 10/24/17 00:31, Jini George wrote:
>>>> Adding hotspot-dev too.
>>>>
>>>> Thanks,
>>>> Jini.
>>>>
>>>> On 10/24/2017 12:05 PM, Jini George wrote:
>>>>> Hello,
>>>>>
>>>>> As a part of SA next, I am working on writing a test case which
>>>>> compares the fields and the types of the fields of the SA java
>>>>> classes with the corresponding entries in the vmStructs tables.
>>>>> This, to some extent, would help in preventing errors in SA due to
>>>>> the changes in hotspot. As a precursor to this, I am in the process
>>>>> of making some cleanup related changes (mostly in SA). I plan to
>>>>> have the changes done in parts. For this webrev, most of the
>>>>> changes are for:
>>>>>
>>>>> 1. Avoiding having some values being redefined in SA. Instead have
>>>>> those exported through vmStructs, and read it in SA.
>>>>> (CompactibleFreeListSpace::_min_chunk_size_in_bytes,
>>>>> CompactibleFreeListSpace::IndexSetSize)
>>>>>
>>>>> Redefinition of hotspot values in SA makes SA error prone, when the
>>>>> value gets altered in hotspot and the corresponding modification
>>>>> gets missed out in SA.
>>>>>
>>>>> 2. To remove some unused code (JNIid.java).
>>>>> 3. Add the missing "CMSBitMap::_bmStartWord" in vmStructs.
>>>>> 4. Modify variable names in SA and hotspot to match the counterpart
>>>>> names, so that the comparison of the fields become easier. Most of
>>>>> the changes belong to this group.
>>>>>
>>>>> Could I please get reviews done for these precursor changes ?
>>>>>
>>>>> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8189798
>>>>> webrev: http://cr.openjdk.java.net/~jgeorge/8189798/webrev.00/
>>>>>
>>>>> Thank you,
>>>>> Jini.
>>>>>
>>>
More information about the hotspot-runtime-dev
mailing list