RFR(XXS) 8190357: NMT: Include metadata information in NMT final report when PrintNMTStatistics is on

[Andrew Dinn]

On 10/11/17 12:47, Zhengyu Gu wrote:
> On 11/10/2017 04:22 AM, Andrew Dinn wrote:
<snip>
>> I understand the need here to avoid reporting if we are under a fatal
>> error. However, that assert is not going to work in product code. So,
>> does that not imply that execution of the vmop needs to be conditional
>> on VMError::fatal_error_in_progress() returning false?
> 
> MemTracker::report() is a private method, only called by
> MemTracker::final_report() and MemTracker::error_report(). This
> assertion ensures that metadata report should never be included in
> MemTracker::error_report() if it decides to extend beyond summary report.
> 
> Of course, this is under assumption that final_report() is called during
> JVM normal shutdown (good state) and error_report() is by error handler
> (bad state).

Ok, thanks for the explanation. The change looks fine.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander