RFR(L) JDK-8188791 Move AppCDS from closed repo to open repo

[Ioi Lam]

Hi Yumin,

Thanks for the review. I have changed it to SHARE_PRIMS_CDOFFSETS_HPP.

- Ioi


On 11/15/17 9:52 AM, yumin qi wrote:
> HI, Ioi
>
> Only one minor comment,  in cdsoffsets.hpp:
> #ifndef CLOSED_VM_PRIMS_CDSWHITEBOX_HPP
> Should it be changed to SHARE_PRIMS_CDOFFSETS_HPP to keep it with same 
> style with other head files.
> Since the hotspot directory changed, I don't know if all head files 
> should change to follow that (changes).
> Thanks
> Yumin
>
> On Tue, Oct 31, 2017 at 7:43 PM, Ioi Lam <ioi.lam at oracle.com 
> <mailto:ioi.lam at oracle.com>> wrote:
>
>     Hi,
>
>     Here's the new webrev for both the AppCDS implementation and
>     tests. During internal review of the JEP, we have decided to
>     integrate both implementation and tests at the same time.
>
>     http://cr.openjdk.java.net/~iklam/jdk10/8188791-open-appcds.v02/
>     <http://cr.openjdk.java.net/%7Eiklam/jdk10/8188791-open-appcds.v02/>
>
>     As mentioned before, most of the "diffs" shown in this webrev are
>     the result of copying the closed source files on top of files of
>     the same name in the open repo. So in reviewing, instead of
>     focusing on what's "changed", please focus on the entire content
>     of the new version of each file.
>
>     Testing: I did an OpenJDK linux-x64 build (without Oracle closed
>     sources) and all the new appcds tests passed.
>
>     Thanks
>
>     - Ioi
>
>
>     On 10/30/17 8:52 AM, Ioi Lam wrote:
>
>         Hi Dmitry,
>
>         In the latest JDK 10 repo, is_jrt has been renamed to
>         is_modules_image. Please change the code accordingly.
>
>         I will post my latest diff soon, with some test cases as well.
>
>         Thanks
>
>         - Ioi
>
>
>         On 10/30/17 4:04 AM, Dmitry Samersoff wrote:
>
>             Ioi,
>
>             I'd tried to apply your patch to latest open JDK10 and
>             the compilation fails with:
>
>             /root/dsamersoff/ESC/appcds/hs/src/hotspot/share/classfile/systemDictionaryShared.cpp:400:16:
>
>             error: ‘class SharedClassPathEntry’ has no member named
>             ‘is_jrt’
>
>             Did I miss something?
>
>             -Dmitry
>
>             On 13.10.2017 02:48, Ioi Lam wrote:
>
>                 Hi,
>
>                 Please review this change set.
>
>                 http://cr.openjdk.java.net/~iklam/jdk10/8188791-open-appcds-impl.v01/
>                 <http://cr.openjdk.java.net/%7Eiklam/jdk10/8188791-open-appcds-impl.v01/>
>                 https://bugs.openjdk.java.net/browse/JDK-8188791
>                 <https://bugs.openjdk.java.net/browse/JDK-8188791>
>
>                 This is the first step of implementing the following
>                 JEP, which moves
>                 AppCDS from
>                 closed repos into the openjdk repo:
>
>                 https://bugs.openjdk.java.net/browse/JDK-8185996
>                 <https://bugs.openjdk.java.net/browse/JDK-8185996>
>
>                 In JDK 9, significant portion of AppCDS code resided
>                 in the closed repo.
>                 As part
>                 of the open-sourcing effort of JDK 18.3, we will move
>                 the source code
>                 into the
>                 open repo.
>
>                 In this changeset, the code is moved verbatim as much
>                 as possible. The
>                 intention is
>                 only to relocate the sources, not to changing existing
>                 behaviors, and not
>                 to do any sort of refactoring.
>
>                 Most of the "diffs" shown in this webrev are the
>                 result of copying the
>                 closed source
>                 files on top of files of the same name in the open
>                 repo. So in
>                 reviewing, instead of
>                 focusing on what's "changed", it's better to focus on
>                 the entire content
>                 of the new
>                 version of each file.
>
>                 The only functional change in this task is that the
>                 UseAppCDS flag is
>                 changed from
>                 a "commercial" flag to a regular "product" flag. This
>                 is because
>                 "commercial"
>                 flags are not supported by the OpenJDK build.
>
>                 Source code refactoring may be desirable, because the
>                 old open/closed
>                 source
>                 code structure had introduced some intermediary APIs
>                 to connect code
>                 between
>                 the two repos. Such API should be removed in a
>                 separate RFE.
>
>                 Also, some AppCDS tests are currently in the closed
>                 repo. These tests
>                 will be
>                 moved in a separate task. See JDK-8188792 for details.
>
>                 All the AppCDS tests (currently still in closed
>                 sources) passed with
>                 both Oracle JDK
>                 and OpenJDK.
>
>                 Thanks
>                 - Ioi
>
>
>
>
>