RFR(XXS) 8190357: NMT: Include metadata information in NMT final report when PrintNMTStatistics is on
Zhengyu Gu
zgu at redhat.com
Fri Nov 17 01:02:44 UTC 2017
Thanks for the review, Thomas.
-Zhengyu
On 11/16/2017 07:27 PM, Thomas Stüfe wrote:
> Hi zhengyu,
>
> The change looks fine. No objection from my side.
>
> Thanks, Thomas
>
> On Fri 17. Nov 2017 at 00:31, Zhengyu Gu <zgu at redhat.com
> <mailto:zgu at redhat.com>> wrote:
>
> Hi Thomas,
>
> Have you gotten chance to review this? I would like to get this in
> before door closes for jdk10.
>
> Thanks,
>
> -Zhengyu
>
>
>
> On 11/10/2017 08:20 AM, Thomas Stüfe wrote:
> > Hi Zhengyu,
> >
> > Cannot test it before monday, but change looks good. Thank you for
> > doing this.
> >
> > ..Thomas
> >
> > On Thu 9. Nov 2017 at 20:33, Zhengyu Gu <zgu at redhat.com
> <mailto:zgu at redhat.com>
> > <mailto:zgu at redhat.com <mailto:zgu at redhat.com>>> wrote:
> >
> > This patch adds metadata reporting in NMT final report.
> >
> > What complicates the matter, is that, reporting per-class loader
> > metadata requires a safepoint, so that it can safely walk
> class loaders.
> > So, we only report it when JVM is about to exit in good state.
> >
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8190357
> > Webrev: http://cr.openjdk.java.net/~zgu/8190357/webrev.00/
> <http://cr.openjdk.java.net/%7Ezgu/8190357/webrev.00/>
> >
> >
> > Thanks,
> >
> > -Zhengyu
> >
>
More information about the hotspot-runtime-dev
mailing list