RFR(integration blocker): 8191373: Multiple NUMA nodes expected

[Gustavo Romero]

Hi Volker, Robbin,

@Robbin Could you please tell me against which repo/commit id you created that
diff? It's after consolidation (hs or master repo), right? Just asking because:

gromero at gromero16:~/hg/jdk10/hs/src/hotspot$ fgrep -i SafepointMechanism -RIn
gromero at gromero16:~/hg/jdk10/hs/src/hotspot$ hg id
d85284ccd1bd tip
gromero at gromero16:~/hg/jdk10/hs/src/hotspot$ hg path
default = http://hg.openjdk.java.net/jdk10/hs/
gromero at gromero16:~/hg/jdk10/hs/src/hotspot$ cd ~/hg/jdk10/master/src/hotspot/
gromero at gromero16:~/hg/jdk10/master/src/hotspot$ fgrep -i SafepointMechanism -RIn
gromero at gromero16:~/hg/jdk10/master/src/hotspot$ hg id
be620a591379 tip
gromero at gromero16:~/hg/jdk10/master/src/hotspot$ hg path
default = http://hg.openjdk.java.net/jdk10/master/

But maybe I'm missing something obvious...


Thanks!

Regards,
Gustavo

On 17-11-2017 12:21, Volker Simonis wrote:
> Hi Gustavo,
> 
> as our "PowerPC NUMA expert", do you see any problem with this change?
> 
> Thank yo uand best regards,
> Volker
> 
> 
> On Fri, Nov 17, 2017 at 3:10 PM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>> Hi all, please review.
>>
>> Windows needs to run os::init_2 before allocation polling page to proper
>> setup numa. I saw no reason not to have it for all platforms after init_2.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191373
>>
>> Code below.
>>
>> Tested tier 1-5/1-3
>>
>> Thanks, Robbin
>>
>> diff -r b4d2929683b6 src/hotspot/share/runtime/thread.cpp
>> --- a/src/hotspot/share/runtime/thread.cpp      Fri Nov 17 02:50:51 2017
>> +0100
>> +++ b/src/hotspot/share/runtime/thread.cpp      Fri Nov 17 13:30:28 2017
>> +0100
>> @@ -3560,10 +3560,10 @@
>>    TraceTime timer("Create VM", TRACETIME_LOG(Info, startuptime));
>>
>> -  SafepointMechanism::initialize();
>> -
>>    // Initialize the os module after parsing the args
>>    jint os_init_2_result = os::init_2();
>>    if (os_init_2_result != JNI_OK) return os_init_2_result;
>>
>> +  SafepointMechanism::initialize();
>> +
>>    jint adjust_after_os_result = Arguments::adjust_after_os();
>>    if (adjust_after_os_result != JNI_OK) return adjust_after_os_result;
>