RFR(integration blocker): 8191373: Multiple NUMA nodes expected
Robbin Ehn
robbin.ehn at oracle.com
Mon Nov 20 07:59:49 UTC 2017
Great, thanks Gustavo!
/Robbin
On 2017-11-17 21:01, Gustavo Romero wrote:
> Hi Volker, Robbin!
>
> I could not find any damage to JVM NUMA detection on PPC64 regarding this
> change. So thumbs up from my side.
>
> Regards,
> Gustavo
>
> On 17-11-2017 12:21, Volker Simonis wrote:
>> Hi Gustavo,
>>
>> as our "PowerPC NUMA expert", do you see any problem with this change?
>>
>> Thank yo uand best regards,
>> Volker
>>
>>
>> On Fri, Nov 17, 2017 at 3:10 PM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>>> Hi all, please review.
>>>
>>> Windows needs to run os::init_2 before allocation polling page to proper
>>> setup numa. I saw no reason not to have it for all platforms after init_2.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191373
>>>
>>> Code below.
>>>
>>> Tested tier 1-5/1-3
>>>
>>> Thanks, Robbin
>>>
>>> diff -r b4d2929683b6 src/hotspot/share/runtime/thread.cpp
>>> --- a/src/hotspot/share/runtime/thread.cpp Fri Nov 17 02:50:51 2017
>>> +0100
>>> +++ b/src/hotspot/share/runtime/thread.cpp Fri Nov 17 13:30:28 2017
>>> +0100
>>> @@ -3560,10 +3560,10 @@
>>> TraceTime timer("Create VM", TRACETIME_LOG(Info, startuptime));
>>>
>>> - SafepointMechanism::initialize();
>>> -
>>> // Initialize the os module after parsing the args
>>> jint os_init_2_result = os::init_2();
>>> if (os_init_2_result != JNI_OK) return os_init_2_result;
>>>
>>> + SafepointMechanism::initialize();
>>> +
>>> jint adjust_after_os_result = Arguments::adjust_after_os();
>>> if (adjust_after_os_result != JNI_OK) return adjust_after_os_result;
>>
>
More information about the hotspot-runtime-dev
mailing list