[8u-backport] 8139873: NMT stack traces in output should show mt component

Zhengyu Gu zgu at redhat.com
Wed Nov 22 21:22:36 UTC 2017


Thanks for the quick review, Aleksey.

On 11/22/2017 02:37 PM, Aleksey Shipilev wrote:
> On 11/22/2017 08:25 PM, Zhengyu Gu wrote:
>> Can I get a review for 8u backport of this fix?
>>
>> The original patch did not apply cleanly, with a few minor merge conflicts.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139673
>> Changeset: http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/82d4003d20b2
>> Review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2017-May/023516.html
>>
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/8139673/webrev.8u_backport/
> 
> *) Indenting is off here:
> 
> mallocSiteTable.cpp:
>   137 size_t* pos_idx, MEMFLAGS flags) {
> 
> *) Excess whitespace after "const":
> 
> mallocSiteTable.hpp:
> 
>    58   MEMFLAGS flags() const  { return (MEMFLAGS)_flags; }

Updated: 
http://cr.openjdk.java.net/~zgu/8139673/8139673/webrev.8u_backport.01/

-Zhengyu

> 
> Otherwise still looks good to me.
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-runtime-dev mailing list