RFR(s-ish): 8191101: Show register content in hs-err file on assert

[Thomas Stüfe]

Hi Andrew,

thanks a lot for the quick review!

Pls find comments inline.

On Mon, Nov 27, 2017 at 1:43 PM, Andrew Dinn <adinn at redhat.com> wrote:

> On 27/11/17 10:33, Thomas Stüfe wrote:
> > Ping... Could I please have reviews? Thank you!
> > ..Thomas
>
> This looks ok except that I'm a bit unsure about the changes to
> VMError.cpp, specifically
>
>   1) the message "Life goes on..." printed at the bottom of the loop
>   2) the fact that this replaces the call to ShouldNotReachHere();
>
> I understand that the message is there to give a positive for the test.
> Also that it only gets printed if you suppress error reporting in this
> code. However, to someone who doesn't know that the idea that one might
> continue through to this point is rather misleading and, perhaps,
> confusing. Could this be commented out? Or could the positive
> confirmation just be omitted?
>
>
Okay, I see your point. I will revert back to ShouldNotReachHere() and
change the jtreg test to recognize that as a positive test.


> Anyway, I built and tested on AArch64 and it passed the test (for what
> that indicates about register printing -- as you say a more stringent
> test is needed that allows for different behaviour on different platforms.)
>
>
Could you please quickly run

java -XX:+ShowRegistersOnAssert -XX:ErrorHandlerTest=1

on aarch64 and take a quick glance at the hs-err file, whether it contains
register output?


regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>

Thanks again,

Best Regards, Thomas