RFR(XS): 8191504: CDSTestUtils.isUnableToMap() should check OptionalData region mapping failure

[Jiangli Zhou]

Thanks, Calvin!

Thanks,
Jiangli 

> On Nov 27, 2017, at 3:53 PM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
> 
> +1
> 
> thanks,
> Calvin
> 
>> On 11/27/17, 3:33 PM, Ioi Lam wrote:
>> Looks good. Thanks!
>> 
>> - Ioi
>> 
>> 
>>> On 11/27/17 3:25 PM, Jiangli Zhou wrote:
>>> Hi,
>>> 
>>> Please review following small test fix. CDS has multiple archived
>>> memory regions, which are mapped individually at runtime.
>>> CDSTestUtils.isUnableToMap() checks for mapping failures, but missing
>>> the ‘OptionalData’ memory region. The fix in the webrev adds the
>>> check for ‘OptionalData’ region. It also updated the error checking
>>> for archived heap memory region.
>>> 
>>> webrev: http://cr.openjdk.java.net/~jiangli/8191504/webrev.00/
>>> <http://cr.openjdk.java.net/~jiangli/8191504/webrev.00/>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8191504?filter=14921
>>> <https://bugs.openjdk.java.net/browse/JDK-8191504?filter=14921>
>>> 
>>> Tested with tier1, trer2, tier3, tier4, and tier5.
>>> 
>>> Thanks,
>>> Jiangli
>>