RFR(XS): 8191504: CDSTestUtils.isUnableToMap() should check OptionalData region mapping failure

Jiangli Zhou jiangli.zhou at oracle.com
Tue Nov 28 00:17:38 UTC 2017


Thanks for the review.

Thanks,
Jiangli 

> On Nov 27, 2017, at 4:08 PM, mikhailo <mikhailo.seledtsov at oracle.com> wrote:
> 
> Looks good,
> 
> Misha
> 
> 
>> On 11/27/2017 03:25 PM, Jiangli Zhou wrote:
>> Hi,
>> 
>> Please review following small test fix. CDS has multiple archived memory regions, which are mapped individually at runtime. CDSTestUtils.isUnableToMap() checks for mapping failures, but missing the ‘OptionalData’ memory region. The fix in the webrev adds the check for ‘OptionalData’ region. It also updated the error checking for archived heap memory region.
>> 
>> webrev: http://cr.openjdk.java.net/~jiangli/8191504/webrev.00/ <http://cr.openjdk.java.net/~jiangli/8191504/webrev.00/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8191504?filter=14921 <https://bugs.openjdk.java.net/browse/JDK-8191504?filter=14921>
>> 
>> Tested with tier1, trer2, tier3, tier4, and tier5.
>> 
>> Thanks,
>> Jiangli
> 



More information about the hotspot-runtime-dev mailing list