RFR[S] 8191927 Enable AppCDS for custom loaders on all 64-bit Linux and AIX

[Volker Simonis]

Hi Ioi,

the change and your refactorings to it look good :) I specially like
the introduction of  "@requires vm.cds.custom.loaders" to simplify the
logic.

I've only found two little problems:

- the patch for the test
"cacheObject/CheckCachedResolvedReferences.java" is empty. That's
probably because it is not related to AppCDS. But the test can and
should still run on all 64-bit Linux and AIX platfroms as well.

- the following two tests still get executed in the product build
where they fail because they use non-product flags:
runtime/appcds/DumpClassList.java
runtime/appcds/ProhibitedPackage.java

I think you fixed that in one of your previous patches but it probably
got lost again before pushing.

The attached "addon.patch" fixes these two problems.

Thank you and bet regards,
Volker


On Mon, Nov 27, 2017 at 10:42 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
> Hi,
>
> Please review this change to support AppCDS on all 64-bit Linux platforms as
> well as AIX.
>
>     https://bugs.openjdk.java.net/browse/JDK-8191927
> http://cr.openjdk.java.net/~iklam/jdk10/8191927-appcds-custom-loader-for-more-platforms.v01/
>
> The patch must be applied on top of the AppCDS patch:
>
> http://cr.openjdk.java.net/~iklam/jdk10/8188791-open-appcds.v03/
>
> The patch was initially contributed by Volker Simonis. I modified it a
> little to avoid repeating the platform enumerations in all the test cases.
> Instead, I added a new test property, so the tests that require AppCDS
> support for custom loaders can be written as:
>
>     * @requires vm.cds.custom.loaders
>
> I've tested on Linux manually, and I am now running on all of the
> Oracle-supported platforms using our internal test harness.
>
> Thanks
> - Ioi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: addon.patch
Type: text/x-patch
Size: 2034 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20171128/65329f1d/addon-0001.patch>