RFR[XS] 8191747 [TESTBUG] runtime/appcds/DumpClassList.java and ProhibitedPackage.java fail on product bits

[Ioi Lam]

Hi Jiangli,

Thanks for the review.

On 11/28/17 10:19 AM, Jiangli Zhou wrote:
> Hi Ioi,
>
> For the following check at line 72 in ProhibitedPackage.java, can you 
> include more complete logging output "[info][class,load] 
> java.lang.Prohibited”? So other output message for 
> java.lang.Prohibited would not be mistakenly matched for this check. 
> No new webrev needed for me with the shouldNotContain() content change.
>
> .shouldNotContain("java.lang.Prohibited")

Good idea! I changed it to

             .shouldNotContain("[info][class,load] java.lang.Prohibited 
source: ")

so it won't be confused with other messages that could possibly have the 
string "java.lang.Prohibited" in it.

> I noticed you didn't have the tests mentioned in the email. Could you 
> please list the tests that you run?
>
I ran all the appcds tests on Linux/x64 in both product and debug 
builds. The names of the two tests are mentioned in the subject of this 
email :-)

Thanks
- Ioi
> Thanks,
> Jiangli
>
>> On Nov 28, 2017, at 9:58 AM, Ioi Lam <ioi.lam at oracle.com 
>> <mailto:ioi.lam at oracle.com>> wrote:
>>
>> Hi,
>>
>> Here's a fix for these two tests failing in product builds. The fix 
>> is to replace the use of debug flag PrintSystemDictionaryAtExit flag 
>> with -Xlog:class+load, which is available in product builds:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8191747
>> http://cr.openjdk.java.net/~iklam/jdk10/8191747-avoid-PrintSystemDictionaryAtExit-in-tests.v01/
>>
>> Thanks
>> - Ioi
>>
>