RFR(XS): 8191787 - move private inline functions from thread.inline.hpp -> thread.cpp

[Daniel D. Daugherty]

Thanks for taking another look!

Dan


On 11/30/17 1:57 PM, coleen.phillimore at oracle.com wrote:
>
> Looks great!
> Coleen
>
> On 11/30/17 10:49 AM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> I have updated the fix based on Coleen's and David H's code reviews.
>>
>> Delta webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/8191787-webrev/jdk10-1-delta/
>>
>> Full webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/8191787-webrev/jdk10-1-full/
>>
>> Thanks, in advance, for any comments, questions or suggestions.
>>
>> Dan
>>
>> On 11/29/17 4:16 PM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> Coleen, this is one of your Thread-SMR follow-up suggestions so I need
>>> to hear from you on this thread. Thanks!
>>>
>>> I have a simple cleanup fix for Thread-SMR. The bug is:
>>>
>>>     JDK-8191787 move private inline functions from thread.inline.hpp 
>>> -> thread.cpp
>>>     https://bugs.openjdk.java.net/browse/JDK-8191787
>>>
>>> This fix is pure code motion:
>>>
>>> - moving inline functions from thread.inline.hpp -> thread.cpp
>>> - making a few functions in thread.hpp private instead of public
>>>
>>> Here is the webrev URL:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8191787-webrev/jdk10-0
>>>
>>> This fix was (over) tested with a Mach5 tier[1-5] run. There were no
>>> unexpected test failures.
>>>
>>> Thanks, in advance, for any comments, questions or suggestions.
>>>
>>> Dan
>>>
>>
>