RFR: 8179387: Factor out CMS specific code from GenCollectedHeap into its own subclass

Erik Helin erik.helin at oracle.com
Mon Oct 2 12:22:37 UTC 2017


On 09/29/2017 03:47 AM, Roman Kennke wrote:>>> Differential:
>>> http://cr.openjdk.java.net/~rkennke/8179387/webrev.08.diff/
>>> <http://cr.openjdk.java.net/%7Erkennke/8179387/webrev.08.diff/>
>>
>> Thanks, this is good.  I don't know enough about the rest of the 
>> change to be a reviewer, but I think you have your reviews.
>> Coleen
>>
>>> Full:
>>> http://cr.openjdk.java.net/~rkennke/8179387/webrev.08/
>>> <http://cr.openjdk.java.net/%7Erkennke/8179387/webrev.08/>
> 
> Ping? I believe this never actually went in. Is there anything missing? 

Sigh, sorry, I completely forgot about this patch, thanks for pinging. 
Yes, this looks good, and thank you for taking on this work!

> Do you want me to re-base it onto the single-repo and post another webrev?

If you don't mind, then yes, please rebase it on top of the consolidated 
repo. Then I can sponsor it for you.

Thanks,
Erik

> Roman


More information about the hotspot-runtime-dev mailing list