RFR(S): 8185694: Replace SystemDictionaryShared::_java_platform_loader with SystemDictionary::is_platform_class_loader()

Calvin Cheung calvin.cheung at oracle.com
Wed Oct 4 17:12:34 UTC 2017


Mandy, David,

Thanks for the review.

I've made the change based on your suggestion:
http://cr.openjdk.java.net/~ccheung/8185694/webrev.01/

thanks,
Calvin

On 10/4/17, 8:29 AM, mandy chung wrote:
>
>
> On 10/3/17 11:36 PM, David Holmes wrote:
>> Hi Calvin,
>>
>> On 4/10/2017 7:26 AM, Calvin Cheung wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8185694
>>>
>>> The open code change for this fix involves adding the 
>>> _java_platform_loader to the SystemDictionary class.
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8185694/webrev.00/
>>
>> I think you should be calling getPlatformClassLoader rather than 
>> poking at the parent field of the system loader. That way you don't 
>> have to worry about whether or not the system loader has been 
>> customized by the user.
> Agree.  ClassLoader::getPlatformClassLoader is the right way to get 
> the platform class loader.
>
> Mandy


More information about the hotspot-runtime-dev mailing list