RFR(S): 8185694: Replace SystemDictionaryShared::_java_platform_loader with SystemDictionary::is_platform_class_loader()

[David Holmes]

On 6/10/2017 10:59 AM, Calvin Cheung wrote:
> updated webrev: http://cr.openjdk.java.net/~ccheung/8185694/webrev.03/

src/hotspot/share/classfile/systemDictionary.hpp

// Returns default system loader

Actually returns the system loader whether default or not. Unclear if 
you might actually want two queries: one for default and one for actual 
(which has the default as its parent)

// Returns default platform loader

You don't need to say "default" as there is only ever one platform loader.

---

share/classfile/systemDictionary.cpp

  186   return (class_loader == _java_system_loader);

I think you need to restore this to checking both the field or whether 
an instance of the default system loader class - as per previous email - 
to handle the custom system loader case.

The explicit NULL checks will be needed if these can be called before 
the platform/system loaders have been determined. I suspect they can 
given the complex initialization process we have with modules.

Thanks,
David