CSR Review: 8189423: Add option to disable stack overflow checking in primordial thread for use with JNI_CreateJavaJVM

[David Holmes]

Hi Thomas,

On 17/10/2017 6:04 PM, Thomas Stüfe wrote:
> Hi David,
> 
> Just some notes:
> 
> - I am confused about the "primordial thread" naming; I always 
> understood the primordial thread to be the thread running main(), not 
> the thread invoking JNI_CreateJavaVM. I always used this term in this 
> way for AIX related problems. How about "VM-Initializing thread"?

This is about the primordial thread only, not about the VM-initializing 
thread in general. The primordial thread is the initial thread of a 
process that executes main as you note. It is only when that thread is 
used to create the VM that we want to allow disabling of the stack guard 
pages.

> - Would this not also be a useful feature for other threads attached to 
> the VM (AttachCurrentThread), as those threads may use a different 
> SO-handling scheme too ?

Perhaps but I'm not going there :) This is just a concession to a 
particular execution scenario.

> Other than that, I think this is a useful addition. Would have helped me 
> before on AIX (see https://bugs.openjdk.java.net/browse/JDK-8179327)

Thanks,
David

> Kind Regards, Thomas
> 
> 
> 
> On Tue, Oct 17, 2017 at 9:22 AM, David Holmes <david.holmes at oracle.com 
> <mailto:david.holmes at oracle.com>> wrote:
> 
>     CSR: https://bugs.openjdk.java.net/browse/JDK-8189423
>     <https://bugs.openjdk.java.net/browse/JDK-8189423>
> 
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8189170
>     <https://bugs.openjdk.java.net/browse/JDK-8189170>
> 
>     Could I please have a reviewer for this CSR request so I can
>     fast-track it.
> 
>     Comments on the proposal are of course welcome.
> 
>     Thanks,
>     David
> 
>