CSR Review: 8189423: Add option to disable stack overflow checking in primordial thread for use with JNI_CreateJavaJVM

[Robbin Ehn]

Hi David,

On 2017-10-17 17:11, Thomas Stüfe wrote:
> Hi David,
> 
> I understand that you want to have a quick solution to a specific problem. I do not like adding a switch with such a narrow usage and would prefer, like Robin, a more well rounded and more general solution.
> 
> That said, I do not see any specific problems with the proposed switch. Not even sure if that matters, as I am not even sure I can review CSRs :)

+1

> 
>     Not sure what you consider "broken". The current approach causes a problem for runtimes that want to do their own stack guards. The proposal is to allow them by giving a flag to turn ours off - but only for the primordial thread, as that is where the problem lies.
> 

The issue I had in 1.6 seems to work fine now. I would still prefer the generic one, but I see your point in not wanting to expose that.

> 
>     The option would ONLY skip for the PRIMORDIAL thread of the process when it loads the VM - hence it has exactly the right name. I specifically do not want to allow this for an arbitrary thread that happens to do the loading of the VM.
> 

Yes your option have exactly the right name :)
I didn't know that we had cross platform reliable ways of knowing if a thread is the primordial one, but it looks like we have something like that.

Thanks, Robbin