RFR: 8189276: Make SuspendibleThreadSet and related code available to other GCs
Zhengyu Gu
zgu at redhat.com
Wed Oct 18 15:00:38 UTC 2017
Looks good to me.
-Zhengyu
On 10/18/2017 10:57 AM, Roman Kennke wrote:
> Hi Zhengyu,
>
> thanks for reviewing. I changed to SHARE_GC_SHARED_... :
>
> http://cr.openjdk.java.net/~rkennke/8189276/webrev.04/
> <http://cr.openjdk.java.net/%7Erkennke/8189276/webrev.04/>
>
> Good now?
>
> Roman
>
>> Hi Roman,
>>
>> This looks much better.
>>
>> Please fix this:
>>
>> src/hotspot/share/gc/shared/suspendibleThreadSet.hpp
>>
>> 25 #ifndef SHARE_GC_COMMON_SUSPENDIBLETHREADSET_HPP
>> 26 #define SHARE_GC_COMMON_SUSPENDIBLETHREADSET_HPP
>>
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>>> I tend to agree that avoiding the new gc/common directory is
>>>> probably a win right now. Hope you agree with this.
>>> Sure. This sounds like the best solution so far. Basically back to my
>>> original plan :-)
>>>
>>> http://cr.openjdk.java.net/~rkennke/8189276/webrev.02/
>>> <http://cr.openjdk.java.net/%7Erkennke/8189276/webrev.02/>
>>>
>>> Haven't tested minimal build though.
>>>
>>> Roman
>>>
>
More information about the hotspot-runtime-dev
mailing list