Review Request JDK-8189193: FindClass mistakenly uses system class loader when the initiating loader is bootstrap loader

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Oct 19 11:35:42 UTC 2017



On 10/19/17 2:47 AM, David Holmes wrote:
> On 19/10/2017 3:50 PM, mandy chung wrote:
>> On 10/18/17 9:09 PM, David Holmes wrote:
>>> No problem with separate test, just wondering if it should be 
>>> somewhere else (with the other tests), or whether those other tests 
>>> will end up in the FindClass directory? 
>>
>> The new test I added is in 
>> test/jdk/java/lang/ClassLoader/nativeLibrary which is about loading 
>> and unloading native library.
>>
>> The existing FindClass tests are tonga tests.  I am not sure if there 
>> are other FindClass tests under test/hotspot/jtreg but at least I 
>> don't find them yet.
>>
>> I think test/hotspot/runtime/jni/FindClass is a good location to me.  
>> Do you have any better suggestion?
>
> No that's fine. There's no single good location when tested 
> functionality overlaps.

I agree.  I like having a sample in hotspot/runtime.

Coleen
>
> Thanks,
> David
>
>> Mandy



More information about the hotspot-runtime-dev mailing list