RFR: 8186789: CDS dump crashes at ConstantPool::resolve_class_constants

Jiangli Zhou jiangli.zhou at oracle.com
Sat Sep 2 16:24:19 UTC 2017


Thanks, Serguei!

Thanks,
Jiangli 

> On Sep 1, 2017, at 9:45 PM, "serguei.spitsyn at oracle.com" <serguei.spitsyn at oracle.com> wrote:
> 
> Hi Jiangli,
> 
> It looks good to me.
> 
> Thanks,
> Serguei
> 
> 
>> On 9/1/17 12:26, Jiangli Zhou wrote:
>> Hi,
>> 
>> Please review the following fix for 8186789.
>> 
>> webrev: http://cr.openjdk.java.net/~jiangli/8186789/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8186789
>> 
>> If a class fails verification due to missing dependencies at dump time, the constant pool _cache may be NULL. ConstantPool::resolve_class_constants() needs to check for that case. Also moved the function under #if INCLUDE_CDS_JAVA_HEAP, since it is only used when INCLUDE_CDS_JAVA_HEAP is enabled.
>> 
>> Tested with JPRT and unit test case.
>> 
>> Thanks,
>> Jiangli
> 



More information about the hotspot-runtime-dev mailing list