RFR: 8186789: CDS dump crashes at ConstantPool::resolve_class_constants

[Jiangli Zhou]

> On Sep 12, 2017, at 9:50 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> Since the function ConstantPool::resolve_class_constants(TRAPS) always returns true, maybe it should be changed to a void function?

That sounds ok to me.

Thanks,
Jiangli

> 
> Thanks
> 
> - Ioi
> 
> 
> On 9/1/17 12:26 PM, Jiangli Zhou wrote:
>> Hi,
>> 
>> Please review the following fix for 8186789.
>> 
>> webrev: http://cr.openjdk.java.net/~jiangli/8186789/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8186789
>> 
>> If a class fails verification due to missing dependencies at dump time, the constant pool _cache may be NULL. ConstantPool::resolve_class_constants() needs to check for that case. Also moved the function under #if INCLUDE_CDS_JAVA_HEAP, since it is only used when INCLUDE_CDS_JAVA_HEAP is enabled.
>> 
>> Tested with JPRT and unit test case.
>> 
>> Thanks,
>> Jiangli
>> 
>