RFR(S): 8138600: eliminate the need of ModuleLoaderMap.dat for CDS

Calvin Cheung calvin.cheung at oracle.com
Tue Sep 12 23:28:21 UTC 2017


Hi Jiangli,

Thanks for your quick review.

On 9/12/17, 3:53 PM, Jiangli Zhou wrote:
> Hi Calvin,
>
> Glad to see those code being eliminated.
>
> Please also remove the following in classLoader.hpp. These macros were 
> only used by the module loader map related code.
>
> 43 // Initial sizes of the following arrays are based on the generated ModuleLoaderMap.dat
>    44 #define INITIAL_BOOT_MODULES_ARRAY_SIZE 30
>    45 #define INITIAL_PLATFORM_MODULES_ARRAY_SIZE  15
>
I will remove those as well.

thanks,
Calvin
> Thanks,
> Jiangli
>
>> On Sep 12, 2017, at 3:14 PM, Calvin Cheung <calvin.cheung at oracle.com 
>> <mailto:calvin.cheung at oracle.com>> wrote:
>>
>> With the fix for JDK-8186842 
>> <https://bugs.openjdk.java.net/browse/JDK-8186842>, we no longer need 
>> the ModuleLoaderMap to determine the loader type of a class during 
>> CDS dump time. This change is for removing the ModuleLoaderMap from 
>> the runtime image and the code which references it.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8138600
>>
>> webrevs:
>> http://cr.openjdk.java.net/~ccheung/8138600/jdk/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eccheung/8138600/jdk/webrev.00/>
>> http://cr.openjdk.java.net/~ccheung/8138600/hotspot/webrev.00/
>>
>> Testing:
>>    JPRT
>>    CDS tests
>>    hs-tier3
>>
>> thanks,
>> Calvin
>>
>


More information about the hotspot-runtime-dev mailing list