RFR(S): 8068314: "Java fields that are currently set during shared space dumping" comment is incorrect

Ioi Lam ioi.lam at oracle.com
Fri Sep 15 19:47:45 UTC 2017

Looks good. Thanks!

- Ioi

On 9/15/17 12:29 PM, Jiangli Zhou wrote:
> Hi,
> Please review following changes for 8068314.
> webrev: http://cr.openjdk.java.net/~jiangli/8068314/webrev.00/ <http://cr.openjdk.java.net/~jiangli/8068314/webrev.00/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8068314 <https://bugs.openjdk.java.net/browse/JDK-8068314>
> The change cleans up out dated code and comments in universe_post_init(). The preallocated out_of_memory errors could be used during CDS/AppCDS dump time, especially with the use of java class loader instances and executing java code during dump time. Also, initializing the error messages during dump time has no unwanted side effects on the archived data.
> Tested with CDS/AppCDS related tests.
> Thanks,
> Jiangli

More information about the hotspot-runtime-dev mailing list