RFR(XXS) 8187979 Clean up info printing at CDS dump time

[Jiangli Zhou]

Looks good. Thanks for fixing it.

Jiangli

> On Sep 27, 2017, at 10:58 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> Hi Jiangli,
> 
> Thanks for noticing this. I have added the following to my patch for metaspaceShared.cpp:
> 
> -      tty->print_cr("%s%d space: " SIZE_FORMAT_W(9) " [ %4.1f%% of total] out of " SIZE_FORMAT_W(9) " bytes [100%% used] at " INTPTR_FORMAT,
> +      tty->print_cr("%s%d space: " SIZE_FORMAT_W(9) " [ %4.1f%% of total] out of " SIZE_FORMAT_W(9) " bytes [100.0%% used] at " INTPTR_FORMAT,
> 
> 
> mc  space:     21736 [  0.1% of total] out of     24576 bytes [ 88.4% used] at 0x0000000800000000
> rw  space:   4229896 [ 23.4% of total] out of   4231168 bytes [100.0% used] at 0x0000000800006000
> ro  space:   7227952 [ 40.0% of total] out of   7229440 bytes [100.0% used] at 0x000000080040f000
> md  space:      6064 [  0.0% of total] out of      8192 bytes [ 74.0% used] at 0x0000000800af4000
> od  space:   6404560 [ 35.4% of total] out of   6406144 bytes [100.0% used] at 0x0000000800af6000
> st0 space:    102400 [  0.6% of total] out of    102400 bytes [100.0% used] at 0x00000007bfc00000
> oa0 space:     65536 [  0.4% of total] out of     65536 bytes [100.0% used] at 0x00000007bf800000
> total    :  18058144 [100.0% of total] out of  18067456 bytes [ 99.9% used]
> 
> 
> Thanks
> 
> - Ioi
> 
> On 9/27/17 10:00 AM, Jiangli Zhou wrote:
>> Hi Ioi,
>> 
>> Thanks. The changes look good.
>> 
>> Since you are in the area, could you please also fix “[100% used … " in the dump output for the st* and oa* spaces. 
>> 
>> od  space:   6478224 [ 35.4% of total] out of   6479872 bytes [100.0% used] at 0x0000000800b12000
>> st0 space:    122880 [  0.7% of total] out of    122880 bytes [100% used] at 0x00000007ffc00000
>> 
>> Thanks,
>> Jiangli
>> 
>>> On Sep 26, 2017, at 8:44 PM, Ioi Lam <ioi.lam at oracle.com <mailto:ioi.lam at oracle.com>> wrote:
>>> 
>>> Hi Jiangli,
>>> 
>>> The "xx space:" column is lined up and the "Unknown" row is removed.
>>> 
>>> 
>>> *** Before ***
>>> 
>>> 
>>> mc space:     21736 [  0.1% of total] out of     24576 bytes [ 88.4% used] at 0x0000000800000000
>>> rw space:   4229896 [ 23.4% of total] out of   4231168 bytes [100.0% used] at 0x0000000800006000
>>> ro space:   7227952 [ 40.0% of total] out of   7229440 bytes [100.0% used] at 0x000000080040f000
>>> md space:      6064 [  0.0% of total] out of      8192 bytes [ 74.0% used] at 0x0000000800af4000
>>> od space:   6404560 [ 35.4% of total] out of   6406144 bytes [100.0% used] at 0x0000000800af6000
>>> st0 space:    102400 [  0.6% of total] out of    102400 bytes [100% used] at 0x00000007bfc00000
>>> oa0 space:     65536 [  0.4% of total] out of     65536 bytes [100% used] at 0x00000007bf800000
>>> total   :  18058144 [100.0% of total] out of  18067456 bytes [ 99.9% used]
>>> [3.470s][info ][cds             ] Detailed metadata info (excluding od/st regions; rw stats include md/mc regions):
>>>                         ro_cnt   ro_bytes     % |   rw_cnt rw_bytes     % |  all_cnt  all_bytes     %
>>> --------------------+---------------------------+---------------------------+--------------------------
>>> Unknown             :        0          0   0.0 | 0          0   0.0 |        0          0   0.0
>>> Class               :        0          0   0.0 |     1237 783584  18.4 |     1237     783584   6.8
>>> Symbol              :    36210    1415496  19.6 | 0          0   0.0 |    36210    1415496  12.3
>>> 
>>> 
>>> *** After ***
>>> 
>>> 
>>> mc  space:     21736 [  0.1% of total] out of     24576 bytes [ 88.4% used] at 0x0000000800000000
>>> rw  space:   4229896 [ 23.4% of total] out of   4231168 bytes [100.0% used] at 0x0000000800006000
>>> ro  space:   7227952 [ 40.0% of total] out of   7229440 bytes [100.0% used] at 0x000000080040f000
>>> md  space:      6064 [  0.0% of total] out of      8192 bytes [ 74.0% used] at 0x0000000800af4000
>>> od  space:   6404560 [ 35.4% of total] out of   6406144 bytes [100.0% used] at 0x0000000800af6000
>>> st0 space:    102400 [  0.6% of total] out of    102400 bytes [100% used] at 0x00000007bfc00000
>>> oa0 space:     65536 [  0.4% of total] out of     65536 bytes [100% used] at 0x00000007bf800000
>>> total    :  18058144 [100.0% of total] out of  18067456 bytes [ 99.9% used]
>>> [3.692s][info ][cds             ] Detailed metadata info (excluding od/st regions; rw stats include md/mc regions):
>>>                         ro_cnt   ro_bytes     % |   rw_cnt rw_bytes     % |  all_cnt  all_bytes     %
>>> --------------------+---------------------------+---------------------------+--------------------------
>>> Class               :        0          0   0.0 |     1237 783584  18.4 |     1237     783584   6.8
>>> Symbol              :    36210    1415496  19.6 | 0          0   0.0 |    36210    1415496  12.3
>>> 
>>> 
>>> Thanks
>>> - Ioi
>>> 
>>> 
>>> On 9/26/17 6:02 PM, Jiangli Zhou wrote:
>>>> Hi Ioi,
>>>> 
>>>> Could you please send an updated dump output?
>>>> 
>>>> Thanks,
>>>> Jiangli
>>>> 
>>>>> On Sep 26, 2017, at 3:03 PM, Ioi Lam <ioi.lam at oracle.com <mailto:ioi.lam at oracle.com>> wrote:
>>>>> 
>>>>> A small clean up to removed obsolete info and improve indentation
>>>>> 
>>>>> * https://bugs.openjdk.java.net/browse/JDK-8187979 <https://bugs.openjdk.java.net/browse/JDK-8187979>
>>>>> * http://cr.openjdk.java.net/~iklam/jdk10/8187979-dump-info-cleanup.v01/ <http://cr.openjdk.java.net/%7Eiklam/jdk10/8187979-dump-info-cleanup.v01/>
>>>>> 
>>>>> Webrev doesn't show the lines that has only changes in blank spaces, but you can see the full diff here:
>>>>> 
>>>>> * http://cr.openjdk.java.net/~iklam/jdk10/8187979-dump-info-cleanup.v01/open.patch <http://cr.openjdk.java.net/%7Eiklam/jdk10/8187979-dump-info-cleanup.v01/open.patch>
>>>>> 
>>>>> Thanks
>>>>> 
>>>>> - Ioi
>>>>> 
>>> 
>> 
>