RFR 8198908: Add JVM support for preview features
Lois Foltan
lois.foltan at oracle.com
Thu Apr 5 15:53:49 UTC 2018
On 4/5/2018 11:18 AM, harold seigel wrote:
> Hi,
>
> Please review this fix to implement the JVM part of JEP 12
> <https://bugs.openjdk.java.net/browse/JDK-8195734>. The changes
> involve modifications to JDK major and minor class version processing
> and adding additional logging.
>
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8198908/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8198908
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8200440
>
> This fix was tested with Mach5 tiers 1 and 2 tests and builds on all
> Mach5 platforms, with tiers 3-5 tests on Linux-x64, and with JCK-11
> Lang and VM tests.
>
> Thanks, Harold
>
Looks good but I would really like to see a comment explaining the same
details that are listed in the CSR specification section of JDK-8200440
ahead of the verify_class_version() method in classFileParser.cpp.
I don't need to see another webrev.
Thanks,
Lois
More information about the hotspot-runtime-dev
mailing list