RFR(XXS) 8201242: Include source file/line number when reporting native call stack on supported platforms
Daniel D. Daugherty
daniel.daugherty at oracle.com
Fri Apr 6 18:51:34 UTC 2018
Hi Zhengyu,
Okay, I'm less confused now than when this bug first came in this AM...
This fix is for NMT (which I sort of guessed because it's you :-)).
I've been recently playing with VM_Error::print_native_stack() and
I know that code includes the source file/line number...
On 4/6/18 12:12 PM, Zhengyu Gu wrote:
> Please review this trivial patch that reports source file/line number
> of call stack on supported platforms.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8201242
> Webrev: http://cr.openjdk.java.net/~zgu/8201242/webrev.00/
src/hotspot/share/utilities/nativeCallStack.cpp
No comments.
Thumbs up.
Dan
>
> Before:
> [0x00000000566893b1] os::attempt_reserve_memory_at+0xe1
> [0x000000005684f961] ReservedHeapSpace::try_reserve_heap+0x181
> [0x000000005684fa90] ReservedHeapSpace::try_reserve_range+0xe0
> [0x000000005684d757] ReservedHeapSpace::initialize_compressed_heap+0x2b7
>
> After:
> [0x00000000566892f1] os::attempt_reserve_memory_at+0xe1 (os.cpp:1701)
> [0x000000005684f9b1] ReservedHeapSpace::try_reserve_heap+0x181
> (virtualspace.cpp:394)
> [0x000000005684fae0] ReservedHeapSpace::try_reserve_range+0xe0
> (virtualspace.cpp:441)
> [0x000000005684d7a7]
> ReservedHeapSpace::initialize_compressed_heap+0x2b7
> (virtualspace.cpp:551)
>
>
> Test:
> submit-hs test:
>
> Mach5 mach5-one-zgu-JDK-8201242-20180406-1401-17712: Builds PASSED.
> Testing SUCCESSFUL.
>
> Thanks,
>
> -Zhengyu
More information about the hotspot-runtime-dev
mailing list