RFR(XXS) 8201321: NMT: Unnecessary re-recording thread stack and size when attaching listener to JavaThread
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Tue Apr 10 01:56:12 UTC 2018
This seems fine.
Coleen
On 4/9/18 6:07 PM, David Holmes wrote:
> Hi Zhengyu,
>
> On 10/04/2018 5:07 AM, Zhengyu Gu wrote:
>> Hi,
>>
>> Please review this trivial change, that removed unnecessary call to
>> record Java thread, which should already be done. Also, added
>> assertion to ensure it is the case.
>
> Minor nit:
>
> "Should already setup" => "Should already be setup"
>
> Otherwise looks fine.
>
> Thanks,
> David
>
>
>> This line was added during early NMT work, and it is redundant.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201321
>> Webrev: http://cr.openjdk.java.net/~zgu/8201321/webrev.00/
>>
>> Test:
>>
>> hotspot_runtime on Linux x64 (release and fastdebug)
>> Windows x64 fastdebug
>>
>> Submit-hs tests.
>>
>> Thanks,
>>
>> -Zhengyu
More information about the hotspot-runtime-dev
mailing list