RFR(XS): 8197972: Always verify non-system classes during CDS dump time

[Jiangli Zhou]

> On Apr 17, 2018, at 10:22 AM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
> 
> Hi Jiangli,
> 
> The message won't be printed if the user specifies -Xverify:all or not specifying -Xverify (default to -Xverify:remote) during CDS dump time; it will only be printed if the user specifies -Xverify:none.
> 
> I'd like to keep the message as is.

Ok. On second thought, that sounds reasonable.

Thanks,
Jiangli

> 
> thanks,
> Calvin
> 
> On 4/17/18, 9:26 AM, Jiangli Zhou wrote:
>> Hi Calvin,
>> 
>> The following log output is misleading and seems to imply we restrict CDS dump-time verification to -Xverify:remote. However, we still honor -Xverify:all at dump time if that’s specified by the user. The ‘(-Xverify:remote)’ should be removed from the log message.
>> 
>> 3383       log_info(cds)("All non-system classes will be verified (-Xverify:remote) during CDS dump time.");
>> 
>> Thanks,
>> Jiangli
>> 
>> 
>>> On Apr 13, 2018, at 9:24 AM, Calvin Cheung <calvin.cheung at oracle.com <mailto:calvin.cheung at oracle.com><mailto:calvin.cheung at oracle.com <mailto:calvin.cheung at oracle.com>>> wrote:
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8197972 <https://bugs.openjdk.java.net/browse/JDK-8197972>
>>> 
>>> CSR: https://bugs.openjdk.java.net/browse/JDK-8198849 <https://bugs.openjdk.java.net/browse/JDK-8198849>
>>> 
>>> webrev: http://cr.openjdk.java.net/~ccheung/8197972/webrev.00/ <http://cr.openjdk.java.net/~ccheung/8197972/webrev.00/><http://cr.openjdk.java.net/%7Eccheung/8197972/webrev.00/ <http://cr.openjdk.java.net/%7Eccheung/8197972/webrev.00/>>
>>> 
>>> This change is to default -Xverify to remote during CDS dumping.
>>> If the user specifies -Xverify:none during CDS dumping, the following message will be printed.
>>> 
>>> bash-4.2$ $MYJDK/bin/java -Xverify:none -Xlog:cds -Xshare:dump
>>> [0.003s][info][cds] All non-system classes will be verified (-Xverify:remote) during CDS dump time.
>>> 
>>> The change passed hs-tier1, hs-tier2, and hs-tier3 tests.
>>> 
>>> thanks,
>>> Calvin