RFR(XXXS): 8209149 runtime/RedefineTests/RedefineRunningMethods.java needs a longer timeout

[Daniel D. Daugherty]

I'm planning to push my change to JDK11 to reduce the noise
in my JDK11 test cycles. After that, I typically push quickly
to JDK12 and then you can apply your change over the top of
mine...

Sound like a plan?

Dan

P.S.
May I count you as a reviewer?

On 8/8/18 1:43 PM, coleen.phillimore at oracle.com wrote:
>
> Hi, I have a change to that exact same line that I'm waiting for a 
> code review.
>
> I think the longer timeout is needed because of the extensive logging, 
> which I've removed.  It was added for this bug JDK-8197901 but doesn't 
> belong in this test.  I am going to file a new bug to add logging to a 
> different test to test the fix for JDK-8197901.
>
> Coleen
>
> On 8/8/18 1:34 PM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> I have a trivial change to a test's timeout value. I need a single
>> (R)eviewer for this change.
>>
>>     JDK-8209149 runtime/RedefineTests/RedefineRunningMethods.java 
>> needs a longer timeout
>>     https://bugs.openjdk.java.net/browse/JDK-8209149
>>
>> Here is the diff:
>>
>> $ hg diff
>> diff -r 2afc9aa349ed 
>> test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java
>> --- 
>> a/test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java 
>> Wed Aug 08 13:45:41 2018 +0800
>> +++ 
>> b/test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java 
>> Wed Aug 08 13:32:24 2018 -0400
>> @@ -31,7 +31,7 @@
>>   *          java.instrument
>>   *          jdk.jartool/sun.tools.jar
>>   * @run main RedefineClassHelper
>> - * @run main/othervm -javaagent:redefineagent.jar 
>> -Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace,all=trace:file=all.log 
>> RedefineRunningMethods
>> + * @run main/othervm/timeout=180 -javaagent:redefineagent.jar 
>> -Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace,all=trace:file=all.log 
>> RedefineRunningMethods
>>   */
>>  // Test is executed with full trace logging redirected to a file to 
>> ensure there is no crash during logging anonymous classes - see 
>> JDK-8197901
>>
>>
>> Thanks, in advance, for any comments, suggestions or questions.
>>
>> Dan
>>
>