RFR (S) 8164683: Solaris: JVM abuses thread preemption control

[David Holmes]

Hi Coleen,

On 10/08/2018 1:26 AM, coleen.phillimore at oracle.com wrote:
> Summary: Complete removal of preemption control and command line 
> arguments (were deprecated in 11).
> 
> Tested with hs-tier1-5 on solaris.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8164683.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8164683

Looks good.

src/hotspot/os/solaris/os_solaris.cpp

# include <schedctl.h>

Still needed?

---

One tiny nit in edited comment block:

src/hotspot/share/runtime/objectMonitor.cpp

2091 // spin only ...

s/spin/Spin/

> Tested message manually (I really don't see the point of add testing the 
> message to a test, only to have to remove in 13).

There is no test for obsolete options. Flags are added to the 
./runtime/CommandLine/VMDeprecatedOptions.java test when they are 
deprecated, and then removed from that test when we bump the version to 
their obsolete version (as the test will fail) - that was done under 
"8205615: Start of release updates for JDK 12"

Thanks,
David

> % java -XX:+VMThreadHintNoPreempt -version
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option 
> VMThreadHintNoPreempt; support was removed in 12.0
> java version "12-internal" 2019-03-19
> Java(TM) SE Runtime Environment 19.3 (fastdebug build 
> 12-internal+0-2018-08-08-1809283.coleen.12preempt)
> Java HotSpot(TM) 64-Bit Server VM 19.3 (fastdebug build 
> 12-internal+0-2018-08-08-1809283.coleen.12preempt, mixed mode)
> 
> Thanks,
> Coleen
>