RFR(S): 8209164: [TESTBUG] Apply jtreg skipped status to cds tests

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Thu Aug 9 22:53:21 UTC 2018


   Thank you. This is a good idea.

I thought a bit about this, and this is what I plan to do:
   - leave isUnableToMap() as is, for compatibility and to have this 
method is someone wishes to simply check that w/o throwing the exception
   - introduce a new method to CDSTestUtils, "void 
checkIfAbleToMap(out)", which will do nothing if archive was able to 
map, and will throw a SkippedException if the test was unable to map the 
   - update the rest of the changed files to use checkIfAbleToMap()

Let me know if you have any objections to this plan.

Thank you,

On 8/9/18, 2:40 PM, Jiangli Zhou wrote:
> Hi Misha,
> Would it be easier to let CDSTestUtils.isUnableToMap() throw 
> SkippedException when mapping fails? With that, it would avoid 
> duplicating the following in different tests:
>          if (CDSTestUtils.isUnableToMap(out)) {
>              throw new SkippedException(CDSTestUtils.UnableToMapMsg);
>          }
> Thanks,
> Jiangli
> On 8/9/18 1:50 PM, Mikhailo Seledtsov wrote:
>> Please review this straight forward change. Now that JTReg harness 
>> supports the "skipped status",
>> this change updates CDS and AppCDS tests to use this mechanism where 
>> applicable.
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8209164
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8209164.01/index.html
>>     Testing:
>>         1. Locally: exercised tests under runtime/SharedArchiveFile 
>> and runtime/appcds on Linux-x64
>>            No new failures
>>     2. Run runtime/SharedArchiveFile and runtime/appcds via 
>> distributed test system
>>            Run tier1,tier2
>>            In progress
>> Thank you,
>> Misha

More information about the hotspot-runtime-dev mailing list